Index: chrome/browser/extensions/api/preference/preference_api_prefs_unittest.cc |
diff --git a/chrome/browser/extensions/api/preference/preference_api_prefs_unittest.cc b/chrome/browser/extensions/api/preference/preference_api_prefs_unittest.cc |
index 058fb8f3e4c021d50f06b9c54d95a6f4ca2eeb57..b29474b0202716a4db879eb3c34d0cc6878919eb 100644 |
--- a/chrome/browser/extensions/api/preference/preference_api_prefs_unittest.cc |
+++ b/chrome/browser/extensions/api/preference/preference_api_prefs_unittest.cc |
@@ -49,14 +49,13 @@ class TestPreferenceAPI : public PreferenceAPIBase { |
private: |
// PreferenceAPIBase implementation. |
- virtual ExtensionPrefs* extension_prefs() override { |
+ ExtensionPrefs* extension_prefs() override { |
return test_extension_prefs_->prefs(); |
} |
- virtual ExtensionPrefValueMap* extension_pref_value_map() override { |
+ ExtensionPrefValueMap* extension_pref_value_map() override { |
return test_extension_prefs_->extension_pref_value_map(); |
} |
- virtual scoped_refptr<ContentSettingsStore> content_settings_store() |
- override { |
+ scoped_refptr<ContentSettingsStore> content_settings_store() override { |
return content_settings_->content_settings_store(); |
} |
@@ -71,8 +70,7 @@ class ExtensionControlledPrefsTest : public PrefsPrepopulatedTestBase { |
ExtensionControlledPrefsTest(); |
virtual ~ExtensionControlledPrefsTest(); |
- virtual void RegisterPreferences(user_prefs::PrefRegistrySyncable* registry) |
- override; |
+ void RegisterPreferences(user_prefs::PrefRegistrySyncable* registry) override; |
void InstallExtensionControlledPref(Extension* extension, |
const std::string& key, |
base::Value* value); |
@@ -194,12 +192,12 @@ void ExtensionControlledPrefsTest::EnsureExtensionUninstalled( |
class ControlledPrefsInstallOneExtension |
: public ExtensionControlledPrefsTest { |
- virtual void Initialize() override { |
+ void Initialize() override { |
InstallExtensionControlledPref(extension1(), |
kPref1, |
new base::StringValue("val1")); |
} |
- virtual void Verify() override { |
+ void Verify() override { |
std::string actual = prefs()->pref_service()->GetString(kPref1); |
EXPECT_EQ("val1", actual); |
} |
@@ -211,7 +209,7 @@ TEST_F(ControlledPrefsInstallOneExtension, |
class ControlledPrefsInstallIncognitoPersistent |
: public ExtensionControlledPrefsTest { |
public: |
- virtual void Initialize() override { |
+ void Initialize() override { |
InstallExtensionControlledPref( |
extension1(), kPref1, new base::StringValue("val1")); |
InstallExtensionControlledPrefIncognito( |
@@ -221,7 +219,7 @@ class ControlledPrefsInstallIncognitoPersistent |
EXPECT_EQ("val2", actual); |
} |
- virtual void Verify() override { |
+ void Verify() override { |
// Main pref service shall see only non-incognito settings. |
std::string actual = prefs()->pref_service()->GetString(kPref1); |
EXPECT_EQ("val1", actual); |
@@ -240,7 +238,7 @@ class ControlledPrefsInstallIncognitoSessionOnly |
public: |
ControlledPrefsInstallIncognitoSessionOnly() : iteration_(0) {} |
- virtual void Initialize() override { |
+ void Initialize() override { |
InstallExtensionControlledPref( |
extension1(), kPref1, new base::StringValue("val1")); |
InstallExtensionControlledPrefIncognitoSessionOnly( |
@@ -249,7 +247,7 @@ class ControlledPrefsInstallIncognitoSessionOnly |
std::string actual = incog_prefs->GetString(kPref1); |
EXPECT_EQ("val2", actual); |
} |
- virtual void Verify() override { |
+ void Verify() override { |
// Main pref service shall see only non-incognito settings. |
std::string actual = prefs()->pref_service()->GetString(kPref1); |
EXPECT_EQ("val1", actual); |
@@ -271,7 +269,7 @@ TEST_F(ControlledPrefsInstallIncognitoSessionOnly, |
ControlledPrefsInstallIncognitoSessionOnly) { } |
class ControlledPrefsUninstallExtension : public ExtensionControlledPrefsTest { |
- virtual void Initialize() override { |
+ void Initialize() override { |
InstallExtensionControlledPref( |
extension1(), kPref1, new base::StringValue("val1")); |
InstallExtensionControlledPref( |
@@ -288,7 +286,7 @@ class ControlledPrefsUninstallExtension : public ExtensionControlledPrefsTest { |
UninstallExtension(extension1()->id()); |
} |
- virtual void Verify() override { |
+ void Verify() override { |
EXPECT_FALSE(prefs()->HasPrefForExtension(extension1()->id())); |
std::string actual; |
@@ -303,7 +301,7 @@ TEST_F(ControlledPrefsUninstallExtension, |
// Tests triggering of notifications to registered observers. |
class ControlledPrefsNotifyWhenNeeded : public ExtensionControlledPrefsTest { |
- virtual void Initialize() override { |
+ void Initialize() override { |
using testing::_; |
using testing::Mock; |
using testing::StrEq; |
@@ -368,7 +366,7 @@ class ControlledPrefsNotifyWhenNeeded : public ExtensionControlledPrefsTest { |
registrar.Remove(kPref1); |
incognito_registrar.Remove(kPref1); |
} |
- virtual void Verify() override { |
+ void Verify() override { |
std::string actual = prefs()->pref_service()->GetString(kPref1); |
EXPECT_EQ(kDefaultPref1, actual); |
} |
@@ -378,14 +376,14 @@ TEST_F(ControlledPrefsNotifyWhenNeeded, |
// Tests disabling an extension. |
class ControlledPrefsDisableExtension : public ExtensionControlledPrefsTest { |
- virtual void Initialize() override { |
+ void Initialize() override { |
InstallExtensionControlledPref( |
extension1(), kPref1, new base::StringValue("val1")); |
std::string actual = prefs()->pref_service()->GetString(kPref1); |
EXPECT_EQ("val1", actual); |
prefs()->SetExtensionState(extension1()->id(), Extension::DISABLED); |
} |
- virtual void Verify() override { |
+ void Verify() override { |
std::string actual = prefs()->pref_service()->GetString(kPref1); |
EXPECT_EQ(kDefaultPref1, actual); |
} |
@@ -394,13 +392,13 @@ TEST_F(ControlledPrefsDisableExtension, ControlledPrefsDisableExtension) { } |
// Tests disabling and reenabling an extension. |
class ControlledPrefsReenableExtension : public ExtensionControlledPrefsTest { |
- virtual void Initialize() override { |
+ void Initialize() override { |
InstallExtensionControlledPref( |
extension1(), kPref1, new base::StringValue("val1")); |
prefs()->SetExtensionState(extension1()->id(), Extension::DISABLED); |
prefs()->SetExtensionState(extension1()->id(), Extension::ENABLED); |
} |
- virtual void Verify() override { |
+ void Verify() override { |
std::string actual = prefs()->pref_service()->GetString(kPref1); |
EXPECT_EQ("val1", actual); |
} |
@@ -422,7 +420,7 @@ class MockStringValue : public base::StringValue { |
class ControlledPrefsSetExtensionControlledPref |
: public ExtensionControlledPrefsTest { |
public: |
- virtual void Initialize() override { |
+ void Initialize() override { |
MockStringValue* v1 = new MockStringValue("https://www.chromium.org"); |
MockStringValue* v2 = new MockStringValue("https://www.chromium.org"); |
MockStringValue* v1i = new MockStringValue("https://www.chromium.org"); |
@@ -448,8 +446,7 @@ class ControlledPrefsSetExtensionControlledPref |
testing::Mock::VerifyAndClearExpectations(v2i); |
} |
- virtual void Verify() override { |
- } |
+ void Verify() override {} |
}; |
TEST_F(ControlledPrefsSetExtensionControlledPref, |
ControlledPrefsSetExtensionControlledPref) { } |
@@ -461,13 +458,13 @@ class ControlledPrefsDisableExtensions : public ExtensionControlledPrefsTest { |
ControlledPrefsDisableExtensions() |
: iteration_(0) {} |
virtual ~ControlledPrefsDisableExtensions() {} |
- virtual void Initialize() override { |
+ void Initialize() override { |
InstallExtensionControlledPref( |
extension1(), kPref1, new base::StringValue("val1")); |
// This becomes only active in the second verification phase. |
prefs_.set_extensions_disabled(true); |
} |
- virtual void Verify() override { |
+ void Verify() override { |
std::string actual = prefs()->pref_service()->GetString(kPref1); |
if (iteration_ == 0) { |
EXPECT_EQ("val1", actual); |