Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1090)

Unified Diff: chrome/browser/extensions/api/commands/command_service.h

Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/commands/command_service.h
diff --git a/chrome/browser/extensions/api/commands/command_service.h b/chrome/browser/extensions/api/commands/command_service.h
index 7f39b7d4c336dc40094111b0e7f6b27cb4ffca3c..19cde7e4a9d7f1ade7519ca45147cbb62206c3ad 100644
--- a/chrome/browser/extensions/api/commands/command_service.h
+++ b/chrome/browser/extensions/api/commands/command_service.h
@@ -69,7 +69,7 @@ class CommandService : public BrowserContextKeyedAPI,
// Constructs a CommandService object for the given profile.
explicit CommandService(content::BrowserContext* context);
- virtual ~CommandService();
+ ~CommandService() override;
// BrowserContextKeyedAPI implementation.
static BrowserContextKeyedAPIFactory<CommandService>* GetFactoryInstance();
@@ -179,16 +179,14 @@ class CommandService : public BrowserContextKeyedAPI,
static const bool kServiceRedirectedInIncognito = true;
// ExtensionRegistryObserver.
- virtual void OnExtensionWillBeInstalled(
- content::BrowserContext* browser_context,
- const Extension* extension,
- bool is_update,
- bool from_ephemeral,
- const std::string& old_name) override;
- virtual void OnExtensionUninstalled(
- content::BrowserContext* browser_context,
- const Extension* extension,
- extensions::UninstallReason reason) override;
+ void OnExtensionWillBeInstalled(content::BrowserContext* browser_context,
+ const Extension* extension,
+ bool is_update,
+ bool from_ephemeral,
+ const std::string& old_name) override;
+ void OnExtensionUninstalled(content::BrowserContext* browser_context,
+ const Extension* extension,
+ extensions::UninstallReason reason) override;
// Updates keybindings for a given |extension|'s page action, browser action
// and named commands. Assigns new keybindings and removes relinquished

Powered by Google App Engine
This is Rietveld 408576698