chrome/browser/extensions/api/commands/commands.h - Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/commands/commands.h

Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/commands/command_service.h ('k') | chrome/browser/extensions/api/content_settings/content_settings_api.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/commands/commands.h

diff --git a/chrome/browser/extensions/api/commands/commands.h b/chrome/browser/extensions/api/commands/commands.h

index 423049ac5a4446d2c7026d842b39c94d698400d9..9aa38eae130a77a2d7c8830337d78ca08adf84d8 100644

--- a/chrome/browser/extensions/api/commands/commands.h

+++ b/chrome/browser/extensions/api/commands/commands.h

@@ -8,8 +8,8 @@

#include "chrome/browser/extensions/chrome_extension_function.h"

class GetAllCommandsFunction : public ChromeSyncExtensionFunction {

- virtual ~GetAllCommandsFunction() {}

- virtual bool RunSync() override;

+ ~GetAllCommandsFunction() override {}

+ bool RunSync() override;

DECLARE_EXTENSION_FUNCTION("commands.getAll", COMMANDS_GETALL)

};