chrome/browser/extensions/api/notifications/notifications_apitest.cc - Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/notifications/notifications_apitest.cc

Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/notifications/notifications_api.cc ('k') | chrome/browser/extensions/api/omnibox/omnibox_api.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/notifications/notifications_apitest.cc

diff --git a/chrome/browser/extensions/api/notifications/notifications_apitest.cc b/chrome/browser/extensions/api/notifications/notifications_apitest.cc

index 885f9002883e28a3579cc1db3f2bf6feff9a2d8e..014f19dba907f31f71545b14d0a4d1578388237d 100644

--- a/chrome/browser/extensions/api/notifications/notifications_apitest.cc

+++ b/chrome/browser/extensions/api/notifications/notifications_apitest.cc

@@ -40,7 +40,7 @@ class UserGestureCatcher : public content::NotificationObserver {

content::NotificationService::AllSources());

}

- virtual ~UserGestureCatcher() {}

+ ~UserGestureCatcher() override {}

bool GetNextResult() {

if (results_.empty()) {

@@ -59,9 +59,9 @@ class UserGestureCatcher : public content::NotificationObserver {

}

private:

- virtual void Observe(int type,

- const content::NotificationSource& source,

- const content::NotificationDetails& details) override {

+ void Observe(int type,

+ const content::NotificationSource& source,

+ const content::NotificationDetails& details) override {

results_.push_back(

static_cast<content::Source<extensions::TestSendMessageFunction> >(

source)