Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1354)

Unified Diff: chrome/browser/extensions/api/omnibox/omnibox_api.h

Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/omnibox/omnibox_api.h
diff --git a/chrome/browser/extensions/api/omnibox/omnibox_api.h b/chrome/browser/extensions/api/omnibox/omnibox_api.h
index 036cd63a8381348d8a41a14818d1be906cba7c8f..6db50e1f892745ecb191e479b7b4c044031abaf2 100644
--- a/chrome/browser/extensions/api/omnibox/omnibox_api.h
+++ b/chrome/browser/extensions/api/omnibox/omnibox_api.h
@@ -77,17 +77,17 @@ class OmniboxSendSuggestionsFunction : public ChromeSyncExtensionFunction {
DECLARE_EXTENSION_FUNCTION("omnibox.sendSuggestions", OMNIBOX_SENDSUGGESTIONS)
protected:
- virtual ~OmniboxSendSuggestionsFunction() {}
+ ~OmniboxSendSuggestionsFunction() override {}
// ExtensionFunction:
- virtual bool RunSync() override;
+ bool RunSync() override;
};
class OmniboxAPI : public BrowserContextKeyedAPI,
public ExtensionRegistryObserver {
public:
explicit OmniboxAPI(content::BrowserContext* context);
- virtual ~OmniboxAPI();
+ ~OmniboxAPI() override;
// BrowserContextKeyedAPI implementation.
static BrowserContextKeyedAPIFactory<OmniboxAPI>* GetFactoryInstance();
@@ -96,7 +96,7 @@ class OmniboxAPI : public BrowserContextKeyedAPI,
static OmniboxAPI* Get(content::BrowserContext* context);
// KeyedService implementation.
- virtual void Shutdown() override;
+ void Shutdown() override;
// Returns the icon to display in the omnibox for the given extension.
gfx::Image GetOmniboxIcon(const std::string& extension_id);
@@ -113,12 +113,11 @@ class OmniboxAPI : public BrowserContextKeyedAPI,
void OnTemplateURLsLoaded();
// ExtensionRegistryObserver implementation.
- virtual void OnExtensionLoaded(content::BrowserContext* browser_context,
- const Extension* extension) override;
- virtual void OnExtensionUnloaded(
- content::BrowserContext* browser_context,
- const Extension* extension,
- UnloadedExtensionInfo::Reason reason) override;
+ void OnExtensionLoaded(content::BrowserContext* browser_context,
+ const Extension* extension) override;
+ void OnExtensionUnloaded(content::BrowserContext* browser_context,
+ const Extension* extension,
+ UnloadedExtensionInfo::Reason reason) override;
// BrowserContextKeyedAPI implementation.
static const char* service_name() {
@@ -156,10 +155,10 @@ class OmniboxSetDefaultSuggestionFunction : public ChromeSyncExtensionFunction {
OMNIBOX_SETDEFAULTSUGGESTION)
protected:
- virtual ~OmniboxSetDefaultSuggestionFunction() {}
+ ~OmniboxSetDefaultSuggestionFunction() override {}
// ExtensionFunction:
- virtual bool RunSync() override;
+ bool RunSync() override;
};
// If the extension has set a custom default suggestion via

Powered by Google App Engine
This is Rietveld 408576698