chrome/browser/extensions/api/mdns/dns_sd_registry.h - Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/mdns/dns_sd_registry.h

Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/mdns/dns_sd_device_lister.h ('k') | chrome/browser/extensions/api/mdns/dns_sd_registry_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/mdns/dns_sd_registry.h

diff --git a/chrome/browser/extensions/api/mdns/dns_sd_registry.h b/chrome/browser/extensions/api/mdns/dns_sd_registry.h

index e6dc922744517a126748c8e95518c4e93a8b793e..c85b1fc719312291e24d416f538d023804ea411e 100644

--- a/chrome/browser/extensions/api/mdns/dns_sd_registry.h

+++ b/chrome/browser/extensions/api/mdns/dns_sd_registry.h

@@ -89,12 +89,12 @@ class DnsSdRegistry : public DnsSdDelegate {

local_discovery::ServiceDiscoverySharedClient* discovery_client);

// DnsSdDelegate implementation:

- virtual void ServiceChanged(const std::string& service_type,

- bool added,

- const DnsSdService& service) override;

- virtual void ServiceRemoved(const std::string& service_type,

- const std::string& service_name) override;

- virtual void ServicesFlushed(const std::string& service_type) override;

+ void ServiceChanged(const std::string& service_type,

+ bool added,

+ const DnsSdService& service) override;

+ void ServiceRemoved(const std::string& service_type,

+ const std::string& service_name) override;

+ void ServicesFlushed(const std::string& service_type) override;

DnsSdServiceTypeDataMap service_data_map_;