chrome/browser/extensions/api/mdns/dns_sd_device_lister.h - Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/mdns/dns_sd_device_lister.h

Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/management/management_browsertest.cc ('k') | chrome/browser/extensions/api/mdns/dns_sd_registry.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/mdns/dns_sd_device_lister.h

diff --git a/chrome/browser/extensions/api/mdns/dns_sd_device_lister.h b/chrome/browser/extensions/api/mdns/dns_sd_device_lister.h

index 6e0053c987b491030726dc3afb0ec9d111f835f9..2a98082bd02a78a9f631af863dadb98037968183 100644

--- a/chrome/browser/extensions/api/mdns/dns_sd_device_lister.h

+++ b/chrome/browser/extensions/api/mdns/dns_sd_device_lister.h

@@ -30,11 +30,11 @@ class DnsSdDeviceLister

virtual void Discover(bool force_update);

protected:

- virtual void OnDeviceChanged(

+ void OnDeviceChanged(

bool added,

const local_discovery::ServiceDescription& service_description) override;

- virtual void OnDeviceRemoved(const std::string& service_name) override;

- virtual void OnDeviceCacheFlushed() override;

+ void OnDeviceRemoved(const std::string& service_name) override;

+ void OnDeviceCacheFlushed() override;

private:

// The delegate to notify of changes to services.