Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1135)

Unified Diff: chrome/browser/extensions/api/debugger/debugger_api.cc

Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/debugger/debugger_api.cc
diff --git a/chrome/browser/extensions/api/debugger/debugger_api.cc b/chrome/browser/extensions/api/debugger/debugger_api.cc
index bd1489e53b61b36d1fe1a2142019edf5cc95308b..4745a24bf55b6dd211e89e2dd89983b6d766ecca 100644
--- a/chrome/browser/extensions/api/debugger/debugger_api.cc
+++ b/chrome/browser/extensions/api/debugger/debugger_api.cc
@@ -84,7 +84,7 @@ class ExtensionDevToolsClientHost : public content::DevToolsAgentHostClient,
const Debuggee& debuggee,
infobars::InfoBar* infobar);
- virtual ~ExtensionDevToolsClientHost();
+ ~ExtensionDevToolsClientHost() override;
const std::string& extension_id() { return extension_id_; }
DevToolsAgentHost* agent_host() { return agent_host_.get(); }
@@ -97,26 +97,23 @@ class ExtensionDevToolsClientHost : public content::DevToolsAgentHostClient,
void MarkAsDismissed();
// DevToolsAgentHostClient interface.
- virtual void AgentHostClosed(
- DevToolsAgentHost* agent_host,
- bool replaced_with_another_client) override;
- virtual void DispatchProtocolMessage(
- DevToolsAgentHost* agent_host,
- const std::string& message) override;
+ void AgentHostClosed(DevToolsAgentHost* agent_host,
+ bool replaced_with_another_client) override;
+ void DispatchProtocolMessage(DevToolsAgentHost* agent_host,
+ const std::string& message) override;
private:
void SendDetachedEvent();
// content::NotificationObserver implementation.
- virtual void Observe(int type,
- const content::NotificationSource& source,
- const content::NotificationDetails& details) override;
+ void Observe(int type,
+ const content::NotificationSource& source,
+ const content::NotificationDetails& details) override;
// ExtensionRegistryObserver implementation.
- virtual void OnExtensionUnloaded(
- content::BrowserContext* browser_context,
- const Extension* extension,
- UnloadedExtensionInfo::Reason reason) override;
+ void OnExtensionUnloaded(content::BrowserContext* browser_context,
+ const Extension* extension,
+ UnloadedExtensionInfo::Reason reason) override;
Profile* profile_;
scoped_refptr<DevToolsAgentHost> agent_host_;
@@ -171,16 +168,15 @@ class ExtensionDevToolsInfoBarDelegate : public ConfirmInfoBarDelegate {
private:
explicit ExtensionDevToolsInfoBarDelegate(const std::string& client_name);
- virtual ~ExtensionDevToolsInfoBarDelegate();
+ ~ExtensionDevToolsInfoBarDelegate() override;
// ConfirmInfoBarDelegate:
- virtual void InfoBarDismissed() override;
- virtual Type GetInfoBarType() const override;
- virtual bool ShouldExpireInternal(
- const NavigationDetails& details) const override;
- virtual base::string16 GetMessageText() const override;
- virtual int GetButtons() const override;
- virtual bool Cancel() override;
+ void InfoBarDismissed() override;
+ Type GetInfoBarType() const override;
+ bool ShouldExpireInternal(const NavigationDetails& details) const override;
+ base::string16 GetMessageText() const override;
+ int GetButtons() const override;
+ bool Cancel() override;
std::string client_name_;
ExtensionDevToolsClientHost* client_host_;
« no previous file with comments | « chrome/browser/extensions/api/debugger/debugger_api.h ('k') | chrome/browser/extensions/api/debugger/debugger_apitest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698