chrome/browser/extensions/api/debugger/debugger_apitest.cc - Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/debugger/debugger_apitest.cc

Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/debugger/debugger_api.cc ('k') | chrome/browser/extensions/api/debugger/debugger_extension_apitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/debugger/debugger_apitest.cc

diff --git a/chrome/browser/extensions/api/debugger/debugger_apitest.cc b/chrome/browser/extensions/api/debugger/debugger_apitest.cc

index 04ce863387724a23bb0f9f66ed055f4ca651781f..77e646fa59788973f3e2ec9b45b23c8cf0670076 100644

--- a/chrome/browser/extensions/api/debugger/debugger_apitest.cc

+++ b/chrome/browser/extensions/api/debugger/debugger_apitest.cc

@@ -29,8 +29,8 @@ class DebuggerApiTest : public ExtensionApiTest {

protected:

virtual ~DebuggerApiTest() {}

- virtual void SetUpCommandLine(base::CommandLine* command_line) override;

- virtual void SetUpOnMainThread() override;

+ void SetUpCommandLine(base::CommandLine* command_line) override;

+ void SetUpOnMainThread() override;

// Run the attach function. If |expected_error| is not empty, then the

// function should fail with the error. Otherwise, the function is expected