chrome/browser/extensions/api/cloud_print_private/cloud_print_private_apitest.cc - Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/cloud_print_private/cloud_print_private_apitest.cc

Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/cloud_print_private/cloud_print_private_api.h ('k') | chrome/browser/extensions/api/command_line_private/command_line_private_api.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/cloud_print_private/cloud_print_private_apitest.cc

diff --git a/chrome/browser/extensions/api/cloud_print_private/cloud_print_private_apitest.cc b/chrome/browser/extensions/api/cloud_print_private/cloud_print_private_apitest.cc

index e9a5cd69fc9dfdc1e18a1b7985a48df8e4f5be3f..6088257f108bd263a2c4cca6fbc8f16c0efc7a18 100644

--- a/chrome/browser/extensions/api/cloud_print_private/cloud_print_private_apitest.cc

+++ b/chrome/browser/extensions/api/cloud_print_private/cloud_print_private_apitest.cc

@@ -23,7 +23,7 @@ using ::testing::_;

// A base class for tests below.

class ExtensionCloudPrintPrivateApiTest : public ExtensionApiTest {

public:

- virtual void SetUpCommandLine(CommandLine* command_line) override {

+ void SetUpCommandLine(CommandLine* command_line) override {

ExtensionApiTest::SetUpCommandLine(command_line);

command_line->AppendSwitchASCII(

switches::kCloudPrintURL,

@@ -31,7 +31,7 @@ class ExtensionCloudPrintPrivateApiTest : public ExtensionApiTest {

"cloud_print_private");

}

- virtual void SetUpInProcessBrowserTestFixture() override {

+ void SetUpInProcessBrowserTestFixture() override {

// Start up the test server and get us ready for calling the install

// API functions.

host_resolver()->AddRule("www.cloudprintapp.com", "127.0.0.1");