chrome/browser/extensions/api/cloud_print_private/cloud_print_private_api.h - Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/cloud_print_private/cloud_print_private_api.h

Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/chrome_extensions_api_client.h ('k') | chrome/browser/extensions/api/cloud_print_private/cloud_print_private_apitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/cloud_print_private/cloud_print_private_api.h

diff --git a/chrome/browser/extensions/api/cloud_print_private/cloud_print_private_api.h b/chrome/browser/extensions/api/cloud_print_private/cloud_print_private_api.h

index d5aa3c13ea06db35954f23b85e2f42eeb5a944bc..52a369deb8e783885791355cfdca9d9536784676 100644

--- a/chrome/browser/extensions/api/cloud_print_private/cloud_print_private_api.h

+++ b/chrome/browser/extensions/api/cloud_print_private/cloud_print_private_api.h

@@ -55,10 +55,10 @@ class CloudPrintPrivateSetupConnectorFunction

CloudPrintPrivateSetupConnectorFunction();

protected:

- virtual ~CloudPrintPrivateSetupConnectorFunction();

+ ~CloudPrintPrivateSetupConnectorFunction() override;

// ExtensionFunction:

- virtual bool RunAsync() override;

+ bool RunAsync() override;

};

class CloudPrintPrivateGetHostNameFunction

@@ -70,10 +70,10 @@ class CloudPrintPrivateGetHostNameFunction

CloudPrintPrivateGetHostNameFunction();

protected:

- virtual ~CloudPrintPrivateGetHostNameFunction();

+ ~CloudPrintPrivateGetHostNameFunction() override;

// ExtensionFunction:

- virtual bool RunAsync() override;

+ bool RunAsync() override;

};

class CloudPrintPrivateGetPrintersFunction

@@ -85,13 +85,13 @@ class CloudPrintPrivateGetPrintersFunction

CloudPrintPrivateGetPrintersFunction();

protected:

- virtual ~CloudPrintPrivateGetPrintersFunction();

+ ~CloudPrintPrivateGetPrintersFunction() override;

private:

void SendResults(const std::vector<std::string>& printers);

// ExtensionFunction:

- virtual bool RunAsync() override;

+ bool RunAsync() override;

};

class CloudPrintPrivateGetClientIdFunction

@@ -103,10 +103,10 @@ class CloudPrintPrivateGetClientIdFunction

CloudPrintPrivateGetClientIdFunction();

protected:

- virtual ~CloudPrintPrivateGetClientIdFunction();

+ ~CloudPrintPrivateGetClientIdFunction() override;

// ExtensionFunction:

- virtual bool RunAsync() override;

+ bool RunAsync() override;

};

} // namespace extensions