chrome/browser/extensions/external_policy_loader.h - Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/external_policy_loader.h

Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/external_install_manager.h ('k') | chrome/browser/extensions/external_policy_loader_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/external_policy_loader.h

diff --git a/chrome/browser/extensions/external_policy_loader.h b/chrome/browser/extensions/external_policy_loader.h

index 845deddd685a54bff241d6361104847a35a7a1ca..81e74f4b8021db1eb5b71923d08f405bb0bf501a 100644

--- a/chrome/browser/extensions/external_policy_loader.h

+++ b/chrome/browser/extensions/external_policy_loader.h

@@ -34,7 +34,7 @@ class ExternalPolicyLoader : public ExternalLoader,

ExternalPolicyLoader(ExtensionManagement* settings, InstallationType type);

// ExtensionManagement::Observer implementation

- virtual void OnExtensionManagementSettingsChanged() override;

+ void OnExtensionManagementSettingsChanged() override;

// Adds an extension to be updated to the pref dictionary.

static void AddExtension(base::DictionaryValue* dict,

@@ -42,12 +42,12 @@ class ExternalPolicyLoader : public ExternalLoader,

const std::string& update_url);

protected:

- virtual void StartLoading() override;

+ void StartLoading() override;

private:

friend class base::RefCountedThreadSafe<ExternalLoader>;

- virtual ~ExternalPolicyLoader();

+ ~ExternalPolicyLoader() override;

ExtensionManagement* settings_;

InstallationType type_;