Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Unified Diff: chrome/browser/extensions/external_policy_loader_unittest.cc

Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/external_policy_loader_unittest.cc
diff --git a/chrome/browser/extensions/external_policy_loader_unittest.cc b/chrome/browser/extensions/external_policy_loader_unittest.cc
index 20ffad3474e3057c743d442b1616009098fcb2d0..4c17ce4ff71905824f56d3a3988f18a7f81cb2de 100644
--- a/chrome/browser/extensions/external_policy_loader_unittest.cc
+++ b/chrome/browser/extensions/external_policy_loader_unittest.cc
@@ -70,23 +70,22 @@ class MockExternalPolicyProviderVisitor
EXPECT_TRUE(expected_extensions_.empty());
}
- virtual bool OnExternalExtensionFileFound(const std::string& id,
- const Version* version,
- const base::FilePath& path,
- Manifest::Location unused,
- int unused2,
- bool unused3) override {
+ bool OnExternalExtensionFileFound(const std::string& id,
+ const Version* version,
+ const base::FilePath& path,
+ Manifest::Location unused,
+ int unused2,
+ bool unused3) override {
ADD_FAILURE() << "There should be no external extensions from files.";
return false;
}
- virtual bool OnExternalExtensionUpdateUrlFound(
- const std::string& id,
- const std::string& install_parameter,
- const GURL& update_url,
- Manifest::Location location,
- int unused1,
- bool unused2) override {
+ bool OnExternalExtensionUpdateUrlFound(const std::string& id,
+ const std::string& install_parameter,
+ const GURL& update_url,
+ Manifest::Location location,
+ int unused1,
+ bool unused2) override {
// Extension has the correct location.
EXPECT_EQ(Manifest::EXTERNAL_POLICY_DOWNLOAD, location);
@@ -102,7 +101,7 @@ class MockExternalPolicyProviderVisitor
return true;
}
- virtual void OnExternalProviderReady(
+ void OnExternalProviderReady(
const ExternalProviderInterface* provider) override {
EXPECT_EQ(provider, provider_.get());
EXPECT_TRUE(provider->IsReady());
« no previous file with comments | « chrome/browser/extensions/external_policy_loader.h ('k') | chrome/browser/extensions/external_pref_loader.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698