chrome/browser/extensions/api/spellcheck/spellcheck_api.h - Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/spellcheck/spellcheck_api.h

Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/sockets_udp/sockets_udp_apitest.cc ('k') | chrome/browser/extensions/api/storage/managed_value_store_cache.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/spellcheck/spellcheck_api.h

diff --git a/chrome/browser/extensions/api/spellcheck/spellcheck_api.h b/chrome/browser/extensions/api/spellcheck/spellcheck_api.h

index 382f074a1247be9834519dfa0deaa8c55d908e23..9c976af00f239f1a6008656bd2403e33f5c703ea 100644

--- a/chrome/browser/extensions/api/spellcheck/spellcheck_api.h

+++ b/chrome/browser/extensions/api/spellcheck/spellcheck_api.h

@@ -16,7 +16,7 @@ class SpellcheckAPI : public BrowserContextKeyedAPI,

public ExtensionRegistryObserver {

public:

explicit SpellcheckAPI(content::BrowserContext* context);

- virtual ~SpellcheckAPI();

+ ~SpellcheckAPI() override;

// BrowserContextKeyedAPI implementation.

static BrowserContextKeyedAPIFactory<SpellcheckAPI>* GetFactoryInstance();

@@ -25,12 +25,11 @@ class SpellcheckAPI : public BrowserContextKeyedAPI,

friend class BrowserContextKeyedAPIFactory<SpellcheckAPI>;

// ExtensionRegistryObserver implementation.

- virtual void OnExtensionLoaded(content::BrowserContext* browser_context,

- const Extension* extension) override;

- virtual void OnExtensionUnloaded(

- content::BrowserContext* browser_context,

- const Extension* extension,

- UnloadedExtensionInfo::Reason reason) override;

+ void OnExtensionLoaded(content::BrowserContext* browser_context,

+ const Extension* extension) override;

+ void OnExtensionUnloaded(content::BrowserContext* browser_context,

+ const Extension* extension,

+ UnloadedExtensionInfo::Reason reason) override;

// BrowserContextKeyedAPI implementation.

static const char* service_name() {