chrome/browser/extensions/api/storage/managed_value_store_cache.h - Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/storage/managed_value_store_cache.h

Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/spellcheck/spellcheck_api.h ('k') | chrome/browser/extensions/api/storage/managed_value_store_cache.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/storage/managed_value_store_cache.h

diff --git a/chrome/browser/extensions/api/storage/managed_value_store_cache.h b/chrome/browser/extensions/api/storage/managed_value_store_cache.h

index b33407cb8b64d86adcf4623893465c954c8cead9..a4202be76ae73f45e84220e2f72a3aaaa8b264ab 100644

--- a/chrome/browser/extensions/api/storage/managed_value_store_cache.h

+++ b/chrome/browser/extensions/api/storage/managed_value_store_cache.h

@@ -46,7 +46,7 @@ class ManagedValueStoreCache : public ValueStoreCache,

ManagedValueStoreCache(content::BrowserContext* context,

const scoped_refptr<SettingsStorageFactory>& factory,

const scoped_refptr<SettingsObserverList>& observers);

- virtual ~ManagedValueStoreCache();

+ ~ManagedValueStoreCache() override;

private:

class ExtensionTracker;

@@ -56,17 +56,17 @@ class ManagedValueStoreCache : public ValueStoreCache,

PolicyValueStoreMap;

// ValueStoreCache implementation:

- virtual void ShutdownOnUI() override;

- virtual void RunWithValueStoreForExtension(

+ void ShutdownOnUI() override;

+ void RunWithValueStoreForExtension(

const StorageCallback& callback,

scoped_refptr<const Extension> extension) override;

- virtual void DeleteStorageSoon(const std::string& extension_id) override;

+ void DeleteStorageSoon(const std::string& extension_id) override;

// PolicyService::Observer implementation:

- virtual void OnPolicyServiceInitialized(policy::PolicyDomain domain) override;

- virtual void OnPolicyUpdated(const policy::PolicyNamespace& ns,

- const policy::PolicyMap& previous,

- const policy::PolicyMap& current) override;

+ void OnPolicyServiceInitialized(policy::PolicyDomain domain) override;

+ void OnPolicyUpdated(const policy::PolicyNamespace& ns,

+ const policy::PolicyMap& previous,

+ const policy::PolicyMap& current) override;

// Posted by OnPolicyUpdated() to update a PolicyValueStore on the FILE

// thread.