Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2014)

Unified Diff: chrome/browser/extensions/chrome_app_sorting.h

Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/chrome_app_sorting.h
diff --git a/chrome/browser/extensions/chrome_app_sorting.h b/chrome/browser/extensions/chrome_app_sorting.h
index b47086c474bf6cca75b0ef87239b71fac2818da3..14b76f09124109fee2b5647356d5f8e43975c260 100644
--- a/chrome/browser/extensions/chrome_app_sorting.h
+++ b/chrome/browser/extensions/chrome_app_sorting.h
@@ -25,45 +25,41 @@ class ExtensionScopedPrefs;
class ChromeAppSorting : public AppSorting {
public:
ChromeAppSorting();
- virtual ~ChromeAppSorting();
+ ~ChromeAppSorting() override;
// AppSorting implementation:
- virtual void SetExtensionScopedPrefs(ExtensionScopedPrefs* prefs) override;
- virtual void SetExtensionSyncService(
+ void SetExtensionScopedPrefs(ExtensionScopedPrefs* prefs) override;
+ void SetExtensionSyncService(
ExtensionSyncService* extension_sync_service) override;
- virtual void Initialize(
- const extensions::ExtensionIdList& extension_ids) override;
- virtual void FixNTPOrdinalCollisions() override;
- virtual void EnsureValidOrdinals(
+ void Initialize(const extensions::ExtensionIdList& extension_ids) override;
+ void FixNTPOrdinalCollisions() override;
+ void EnsureValidOrdinals(
const std::string& extension_id,
const syncer::StringOrdinal& suggested_page) override;
- virtual void OnExtensionMoved(
- const std::string& moved_extension_id,
- const std::string& predecessor_extension_id,
- const std::string& successor_extension_id) override;
- virtual syncer::StringOrdinal GetAppLaunchOrdinal(
+ void OnExtensionMoved(const std::string& moved_extension_id,
+ const std::string& predecessor_extension_id,
+ const std::string& successor_extension_id) override;
+ syncer::StringOrdinal GetAppLaunchOrdinal(
const std::string& extension_id) const override;
- virtual void SetAppLaunchOrdinal(
+ void SetAppLaunchOrdinal(
const std::string& extension_id,
const syncer::StringOrdinal& new_app_launch_ordinal) override;
- virtual syncer::StringOrdinal CreateFirstAppLaunchOrdinal(
+ syncer::StringOrdinal CreateFirstAppLaunchOrdinal(
const syncer::StringOrdinal& page_ordinal) const override;
- virtual syncer::StringOrdinal CreateNextAppLaunchOrdinal(
+ syncer::StringOrdinal CreateNextAppLaunchOrdinal(
const syncer::StringOrdinal& page_ordinal) const override;
- virtual syncer::StringOrdinal CreateFirstAppPageOrdinal() const override;
- virtual syncer::StringOrdinal GetNaturalAppPageOrdinal() const override;
- virtual syncer::StringOrdinal GetPageOrdinal(
+ syncer::StringOrdinal CreateFirstAppPageOrdinal() const override;
+ syncer::StringOrdinal GetNaturalAppPageOrdinal() const override;
+ syncer::StringOrdinal GetPageOrdinal(
const std::string& extension_id) const override;
- virtual void SetPageOrdinal(
- const std::string& extension_id,
- const syncer::StringOrdinal& new_page_ordinal) override;
- virtual void ClearOrdinals(const std::string& extension_id) override;
- virtual int PageStringOrdinalAsInteger(
+ void SetPageOrdinal(const std::string& extension_id,
+ const syncer::StringOrdinal& new_page_ordinal) override;
+ void ClearOrdinals(const std::string& extension_id) override;
+ int PageStringOrdinalAsInteger(
const syncer::StringOrdinal& page_ordinal) const override;
- virtual syncer::StringOrdinal PageIntegerAsStringOrdinal(
- size_t page_index) override;
- virtual void SetExtensionVisible(const std::string& extension_id,
- bool visible) override;
+ syncer::StringOrdinal PageIntegerAsStringOrdinal(size_t page_index) override;
+ void SetExtensionVisible(const std::string& extension_id,
+ bool visible) override;
private:
// The StringOrdinal is the app launch ordinal and the string is the extension
« no previous file with comments | « chrome/browser/extensions/chrome_app_api_browsertest.cc ('k') | chrome/browser/extensions/chrome_app_sorting_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698