Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Side by Side Diff: chrome/browser/extensions/chrome_app_sorting.h

Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_EXTENSIONS_CHROME_APP_SORTING_H_ 5 #ifndef CHROME_BROWSER_EXTENSIONS_CHROME_APP_SORTING_H_
6 #define CHROME_BROWSER_EXTENSIONS_CHROME_APP_SORTING_H_ 6 #define CHROME_BROWSER_EXTENSIONS_CHROME_APP_SORTING_H_
7 7
8 #include <map> 8 #include <map>
9 #include <set> 9 #include <set>
10 #include <string> 10 #include <string>
11 11
12 #include "base/basictypes.h" 12 #include "base/basictypes.h"
13 #include "extensions/browser/app_sorting.h" 13 #include "extensions/browser/app_sorting.h"
14 #include "extensions/browser/extension_prefs.h" 14 #include "extensions/browser/extension_prefs.h"
15 #include "extensions/common/extension.h" 15 #include "extensions/common/extension.h"
16 #include "sync/api/string_ordinal.h" 16 #include "sync/api/string_ordinal.h"
17 17
18 class ExtensionSyncService; 18 class ExtensionSyncService;
19 class PrefService; 19 class PrefService;
20 20
21 namespace extensions { 21 namespace extensions {
22 22
23 class ExtensionScopedPrefs; 23 class ExtensionScopedPrefs;
24 24
25 class ChromeAppSorting : public AppSorting { 25 class ChromeAppSorting : public AppSorting {
26 public: 26 public:
27 ChromeAppSorting(); 27 ChromeAppSorting();
28 virtual ~ChromeAppSorting(); 28 ~ChromeAppSorting() override;
29 29
30 // AppSorting implementation: 30 // AppSorting implementation:
31 virtual void SetExtensionScopedPrefs(ExtensionScopedPrefs* prefs) override; 31 void SetExtensionScopedPrefs(ExtensionScopedPrefs* prefs) override;
32 virtual void SetExtensionSyncService( 32 void SetExtensionSyncService(
33 ExtensionSyncService* extension_sync_service) override; 33 ExtensionSyncService* extension_sync_service) override;
34 virtual void Initialize( 34 void Initialize(const extensions::ExtensionIdList& extension_ids) override;
35 const extensions::ExtensionIdList& extension_ids) override; 35 void FixNTPOrdinalCollisions() override;
36 virtual void FixNTPOrdinalCollisions() override; 36 void EnsureValidOrdinals(
37 virtual void EnsureValidOrdinals(
38 const std::string& extension_id, 37 const std::string& extension_id,
39 const syncer::StringOrdinal& suggested_page) override; 38 const syncer::StringOrdinal& suggested_page) override;
40 virtual void OnExtensionMoved( 39 void OnExtensionMoved(const std::string& moved_extension_id,
41 const std::string& moved_extension_id, 40 const std::string& predecessor_extension_id,
42 const std::string& predecessor_extension_id, 41 const std::string& successor_extension_id) override;
43 const std::string& successor_extension_id) override; 42 syncer::StringOrdinal GetAppLaunchOrdinal(
44 virtual syncer::StringOrdinal GetAppLaunchOrdinal(
45 const std::string& extension_id) const override; 43 const std::string& extension_id) const override;
46 virtual void SetAppLaunchOrdinal( 44 void SetAppLaunchOrdinal(
47 const std::string& extension_id, 45 const std::string& extension_id,
48 const syncer::StringOrdinal& new_app_launch_ordinal) override; 46 const syncer::StringOrdinal& new_app_launch_ordinal) override;
49 virtual syncer::StringOrdinal CreateFirstAppLaunchOrdinal( 47 syncer::StringOrdinal CreateFirstAppLaunchOrdinal(
50 const syncer::StringOrdinal& page_ordinal) const override; 48 const syncer::StringOrdinal& page_ordinal) const override;
51 virtual syncer::StringOrdinal CreateNextAppLaunchOrdinal( 49 syncer::StringOrdinal CreateNextAppLaunchOrdinal(
52 const syncer::StringOrdinal& page_ordinal) const override; 50 const syncer::StringOrdinal& page_ordinal) const override;
53 virtual syncer::StringOrdinal CreateFirstAppPageOrdinal() const override; 51 syncer::StringOrdinal CreateFirstAppPageOrdinal() const override;
54 virtual syncer::StringOrdinal GetNaturalAppPageOrdinal() const override; 52 syncer::StringOrdinal GetNaturalAppPageOrdinal() const override;
55 virtual syncer::StringOrdinal GetPageOrdinal( 53 syncer::StringOrdinal GetPageOrdinal(
56 const std::string& extension_id) const override; 54 const std::string& extension_id) const override;
57 virtual void SetPageOrdinal( 55 void SetPageOrdinal(const std::string& extension_id,
58 const std::string& extension_id, 56 const syncer::StringOrdinal& new_page_ordinal) override;
59 const syncer::StringOrdinal& new_page_ordinal) override; 57 void ClearOrdinals(const std::string& extension_id) override;
60 virtual void ClearOrdinals(const std::string& extension_id) override; 58 int PageStringOrdinalAsInteger(
61 virtual int PageStringOrdinalAsInteger(
62 const syncer::StringOrdinal& page_ordinal) const override; 59 const syncer::StringOrdinal& page_ordinal) const override;
63 virtual syncer::StringOrdinal PageIntegerAsStringOrdinal( 60 syncer::StringOrdinal PageIntegerAsStringOrdinal(size_t page_index) override;
64 size_t page_index) override; 61 void SetExtensionVisible(const std::string& extension_id,
65 virtual void SetExtensionVisible(const std::string& extension_id, 62 bool visible) override;
66 bool visible) override;
67 63
68 private: 64 private:
69 // The StringOrdinal is the app launch ordinal and the string is the extension 65 // The StringOrdinal is the app launch ordinal and the string is the extension
70 // id. 66 // id.
71 typedef std::multimap< 67 typedef std::multimap<
72 syncer::StringOrdinal, std::string, 68 syncer::StringOrdinal, std::string,
73 syncer::StringOrdinal::LessThanFn> AppLaunchOrdinalMap; 69 syncer::StringOrdinal::LessThanFn> AppLaunchOrdinalMap;
74 // The StringOrdinal is the page ordinal and the AppLaunchOrdinalMap is the 70 // The StringOrdinal is the page ordinal and the AppLaunchOrdinalMap is the
75 // contents of that page. 71 // contents of that page.
76 typedef std::map< 72 typedef std::map<
(...skipping 102 matching lines...) Expand 10 before | Expand all | Expand 10 after
179 175
180 // The set of extensions that don't appear in the new tab page. 176 // The set of extensions that don't appear in the new tab page.
181 std::set<std::string> ntp_hidden_extensions_; 177 std::set<std::string> ntp_hidden_extensions_;
182 178
183 DISALLOW_COPY_AND_ASSIGN(ChromeAppSorting); 179 DISALLOW_COPY_AND_ASSIGN(ChromeAppSorting);
184 }; 180 };
185 181
186 } // namespace extensions 182 } // namespace extensions
187 183
188 #endif // CHROME_BROWSER_EXTENSIONS_CHROME_APP_SORTING_H_ 184 #endif // CHROME_BROWSER_EXTENSIONS_CHROME_APP_SORTING_H_
OLDNEW
« no previous file with comments | « chrome/browser/extensions/chrome_app_api_browsertest.cc ('k') | chrome/browser/extensions/chrome_app_sorting_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698