Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Unified Diff: chrome/browser/extensions/api/preferences_private/preferences_private_apitest.cc

Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/preferences_private/preferences_private_apitest.cc
diff --git a/chrome/browser/extensions/api/preferences_private/preferences_private_apitest.cc b/chrome/browser/extensions/api/preferences_private/preferences_private_apitest.cc
index f7d73821659da79ca35c51af3bf7d37f2b5724f2..95908d8331e59c6bc17c6e3469de6ad24a4c138d 100644
--- a/chrome/browser/extensions/api/preferences_private/preferences_private_apitest.cc
+++ b/chrome/browser/extensions/api/preferences_private/preferences_private_apitest.cc
@@ -52,7 +52,7 @@ class FakeProfileSyncService : public ProfileSyncService {
sync_initialized_(true),
initialized_state_violation_(false) {}
- virtual ~FakeProfileSyncService() {}
+ ~FakeProfileSyncService() override {}
static KeyedService* BuildFakeProfileSyncService(
content::BrowserContext* context) {
@@ -66,12 +66,9 @@ class FakeProfileSyncService : public ProfileSyncService {
bool initialized_state_violation() { return initialized_state_violation_; }
// ProfileSyncService:
- virtual bool SyncActive() const override {
- return sync_initialized_;
- }
+ bool SyncActive() const override { return sync_initialized_; }
- virtual void AddObserver(
- ProfileSyncServiceBase::Observer* observer) override {
+ void AddObserver(ProfileSyncServiceBase::Observer* observer) override {
if (sync_initialized_)
initialized_state_violation_ = true;
// Set sync initialized state to true so the function will run after
@@ -83,7 +80,7 @@ class FakeProfileSyncService : public ProfileSyncService {
base::Unretained(observer)));
}
- virtual syncer::ModelTypeSet GetEncryptedDataTypes() const override {
+ syncer::ModelTypeSet GetEncryptedDataTypes() const override {
if (!sync_initialized_)
initialized_state_violation_ = true;
syncer::ModelTypeSet type_set;
@@ -91,7 +88,7 @@ class FakeProfileSyncService : public ProfileSyncService {
return type_set;
}
- virtual syncer::ModelTypeSet GetPreferredDataTypes() const override {
+ syncer::ModelTypeSet GetPreferredDataTypes() const override {
if (!sync_initialized_)
initialized_state_violation_ = true;
syncer::ModelTypeSet preferred_types =
@@ -114,14 +111,14 @@ class PreferencesPrivateApiTest : public ExtensionApiTest {
PreferencesPrivateApiTest() : browser_(NULL), service_(NULL) {}
virtual ~PreferencesPrivateApiTest() {}
- virtual void SetUpCommandLine(CommandLine* command_line) override {
+ void SetUpCommandLine(CommandLine* command_line) override {
#if defined(OS_CHROMEOS)
command_line->AppendSwitch(
chromeos::switches::kIgnoreUserProfileMappingForTests);
#endif
}
- virtual void SetUpOnMainThread() override {
+ void SetUpOnMainThread() override {
ExtensionApiTest::SetUpOnMainThread();
base::FilePath path;

Powered by Google App Engine
This is Rietveld 408576698