Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(874)

Unified Diff: chrome/browser/extensions/api/principals_private/principals_private_api.h

Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/principals_private/principals_private_api.h
diff --git a/chrome/browser/extensions/api/principals_private/principals_private_api.h b/chrome/browser/extensions/api/principals_private/principals_private_api.h
index 16f0ef03e42c6c9704695c385673baf83bcd6f6f..5f5d96e0c1745a596f25db6c3e5ec0f949a4b6c8 100644
--- a/chrome/browser/extensions/api/principals_private/principals_private_api.h
+++ b/chrome/browser/extensions/api/principals_private/principals_private_api.h
@@ -19,12 +19,12 @@ class PrincipalsPrivateExtensionFunction : public ChromeSyncExtensionFunction {
PrincipalsPrivateExtensionFunction() {}
protected:
- virtual ~PrincipalsPrivateExtensionFunction() {}
+ ~PrincipalsPrivateExtensionFunction() override {}
// ExtensionFunction:
// Checks for the flag "new-profile-management", if set calls
// RunSyncSafe which must be overriden by subclasses.
- virtual bool RunSync() override final;
+ bool RunSync() final;
private:
virtual bool RunSyncSafe() = 0;
@@ -38,11 +38,11 @@ class PrincipalsPrivateSignOutFunction
PrincipalsPrivateSignOutFunction() {}
protected:
- virtual ~PrincipalsPrivateSignOutFunction() {}
+ ~PrincipalsPrivateSignOutFunction() override {}
private:
// PrincipalsPrivateExtensionFunction
- virtual bool RunSyncSafe() override;
+ bool RunSyncSafe() override;
DISALLOW_COPY_AND_ASSIGN(PrincipalsPrivateSignOutFunction);
};
@@ -55,11 +55,11 @@ class PrincipalsPrivateShowAvatarBubbleFunction
PrincipalsPrivateShowAvatarBubbleFunction() {}
protected:
- virtual ~PrincipalsPrivateShowAvatarBubbleFunction() {}
+ ~PrincipalsPrivateShowAvatarBubbleFunction() override {}
private:
// PrincipalsPrivateExtensionFunction
- virtual bool RunSyncSafe() override;
+ bool RunSyncSafe() override;
DISALLOW_COPY_AND_ASSIGN(PrincipalsPrivateShowAvatarBubbleFunction);
};

Powered by Google App Engine
This is Rietveld 408576698