Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1185)

Unified Diff: chrome/browser/extensions/activity_log/uma_policy.h

Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/activity_log/uma_policy.h
diff --git a/chrome/browser/extensions/activity_log/uma_policy.h b/chrome/browser/extensions/activity_log/uma_policy.h
index c534f62745f923f317444c5727c82a2d0d4e8a9a..50750399a3532d6d7684f06bd6138fb350d65be7 100644
--- a/chrome/browser/extensions/activity_log/uma_policy.h
+++ b/chrome/browser/extensions/activity_log/uma_policy.h
@@ -56,15 +56,15 @@ class UmaPolicy : public ActivityLogPolicy,
explicit UmaPolicy(Profile* profile);
// ActivityLogPolicy implementation.
- virtual void ProcessAction(scoped_refptr<Action> action) override;
- virtual void Close() override;
+ void ProcessAction(scoped_refptr<Action> action) override;
+ void Close() override;
// Gets the histogram name associated with each PageStatus.
static const char* GetHistogramName(PageStatus status);
protected:
// Run when Close() is called.
- virtual ~UmaPolicy();
+ ~UmaPolicy() override;
private:
// Used as a special key in the ExtensionMap.
@@ -77,19 +77,19 @@ class UmaPolicy : public ActivityLogPolicy,
typedef std::map<std::string, ExtensionMap> SiteMap;
// BrowserListObserver
- virtual void OnBrowserAdded(Browser* browser) override;
- virtual void OnBrowserRemoved(Browser* browser) override;
+ void OnBrowserAdded(Browser* browser) override;
+ void OnBrowserRemoved(Browser* browser) override;
// TabStripModelObserver
// Fired when a page loads, either as a new tab or replacing the contents of
// an older tab.
- virtual void TabChangedAt(content::WebContents* contents,
- int index,
- TabChangeType change_type) override;
+ void TabChangedAt(content::WebContents* contents,
+ int index,
+ TabChangeType change_type) override;
// Fired when a tab closes.
- virtual void TabClosingAt(TabStripModel* tab_strip_model,
- content::WebContents* contents,
- int index) override;
+ void TabClosingAt(TabStripModel* tab_strip_model,
+ content::WebContents* contents,
+ int index) override;
// Assign a status bitmask based on the action's properties.
int MatchActionToStatus(scoped_refptr<Action> action);

Powered by Google App Engine
This is Rietveld 408576698