Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1461)

Unified Diff: chrome/browser/extensions/api/activity_log_private/activity_log_private_api.h

Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/activity_log_private/activity_log_private_api.h
diff --git a/chrome/browser/extensions/api/activity_log_private/activity_log_private_api.h b/chrome/browser/extensions/api/activity_log_private/activity_log_private_api.h
index 7e3ddd0ede6066e1f75fd898de60229995382058..f09c5c7fa020070ae068318432a1d0b76a0d88a0 100644
--- a/chrome/browser/extensions/api/activity_log_private/activity_log_private_api.h
+++ b/chrome/browser/extensions/api/activity_log_private/activity_log_private_api.h
@@ -26,12 +26,12 @@ class ActivityLogAPI : public BrowserContextKeyedAPI,
public EventRouter::Observer {
public:
explicit ActivityLogAPI(content::BrowserContext* context);
- virtual ~ActivityLogAPI();
+ ~ActivityLogAPI() override;
// BrowserContextKeyedAPI implementation.
static BrowserContextKeyedAPIFactory<ActivityLogAPI>* GetFactoryInstance();
- virtual void Shutdown() override;
+ void Shutdown() override;
// Lookup whether the extension ID is whitelisted.
static bool IsExtensionWhitelisted(const std::string& extension_id);
@@ -42,12 +42,12 @@ class ActivityLogAPI : public BrowserContextKeyedAPI,
// ActivityLog::Observer
// We pass this along to activityLogPrivate.onExtensionActivity.
- virtual void OnExtensionActivity(scoped_refptr<Action> activity) override;
+ void OnExtensionActivity(scoped_refptr<Action> activity) override;
// EventRouter::Observer
// We only keep track of OnExtensionActivity if we have any listeners.
- virtual void OnListenerAdded(const EventListenerInfo& details) override;
- virtual void OnListenerRemoved(const EventListenerInfo& details) override;
+ void OnListenerAdded(const EventListenerInfo& details) override;
+ void OnListenerRemoved(const EventListenerInfo& details) override;
content::BrowserContext* browser_context_;
ActivityLog* activity_log_;
@@ -68,10 +68,10 @@ class ActivityLogPrivateGetExtensionActivitiesFunction
ACTIVITYLOGPRIVATE_GETEXTENSIONACTIVITIES)
protected:
- virtual ~ActivityLogPrivateGetExtensionActivitiesFunction() {}
+ ~ActivityLogPrivateGetExtensionActivitiesFunction() override {}
// ExtensionFunction:
- virtual bool RunAsync() override;
+ bool RunAsync() override;
private:
void OnLookupCompleted(
@@ -86,10 +86,10 @@ class ActivityLogPrivateDeleteActivitiesFunction
ACTIVITYLOGPRIVATE_DELETEACTIVITIES)
protected:
- virtual ~ActivityLogPrivateDeleteActivitiesFunction() {}
+ ~ActivityLogPrivateDeleteActivitiesFunction() override {}
// ExtensionFunction:
- virtual bool RunAsync() override;
+ bool RunAsync() override;
};
// The implementation of activityLogPrivate.deleteDatabase
@@ -100,10 +100,10 @@ class ActivityLogPrivateDeleteDatabaseFunction
ACTIVITYLOGPRIVATE_DELETEDATABASE)
protected:
- virtual ~ActivityLogPrivateDeleteDatabaseFunction() {}
+ ~ActivityLogPrivateDeleteDatabaseFunction() override {}
// ExtensionFunction:
- virtual bool RunAsync() override;
+ bool RunAsync() override;
};
// The implementation of activityLogPrivate.deleteUrls
@@ -114,10 +114,10 @@ class ActivityLogPrivateDeleteUrlsFunction
ACTIVITYLOGPRIVATE_DELETEURLS)
protected:
- virtual ~ActivityLogPrivateDeleteUrlsFunction() {}
+ ~ActivityLogPrivateDeleteUrlsFunction() override {}
// ExtensionFunction:
- virtual bool RunAsync() override;
+ bool RunAsync() override;
};
} // namespace extensions

Powered by Google App Engine
This is Rietveld 408576698