chrome/browser/extensions/api/push_messaging/push_messaging_invalidation_handler.h - Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/push_messaging/push_messaging_invalidation_handler.h

Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/push_messaging/push_messaging_canary_test.cc ('k') | chrome/browser/extensions/api/reading_list_private/reading_list_private_api.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/push_messaging/push_messaging_invalidation_handler.h

diff --git a/chrome/browser/extensions/api/push_messaging/push_messaging_invalidation_handler.h b/chrome/browser/extensions/api/push_messaging/push_messaging_invalidation_handler.h

index 0f3ca9eb447500c635dfc31744b34625910f9c3c..cdfb7df5234dc964c1e65af1895d786a47758f98 100644

--- a/chrome/browser/extensions/api/push_messaging/push_messaging_invalidation_handler.h

+++ b/chrome/browser/extensions/api/push_messaging/push_messaging_invalidation_handler.h

@@ -36,20 +36,19 @@ class PushMessagingInvalidationHandler : public PushMessagingInvalidationMapper,

PushMessagingInvalidationHandler(

invalidation::InvalidationService* service,

PushMessagingInvalidationHandlerDelegate* delegate);

- virtual ~PushMessagingInvalidationHandler();

+ ~PushMessagingInvalidationHandler() override;

// PushMessagingInvalidationMapper implementation.

- virtual void SuppressInitialInvalidationsForExtension(

+ void SuppressInitialInvalidationsForExtension(

const std::string& extension_id) override;

- virtual void RegisterExtension(const std::string& extension_id) override;

- virtual void UnregisterExtension(const std::string& extension_id) override;

+ void RegisterExtension(const std::string& extension_id) override;

+ void UnregisterExtension(const std::string& extension_id) override;

// InvalidationHandler implementation.

- virtual void OnInvalidatorStateChange(

- syncer::InvalidatorState state) override;

- virtual void OnIncomingInvalidation(

+ void OnInvalidatorStateChange(syncer::InvalidatorState state) override;

+ void OnIncomingInvalidation(

const syncer::ObjectIdInvalidationMap& invalidation_map) override;

- virtual std::string GetOwnerName() const override;

+ std::string GetOwnerName() const override;

const std::set<std::string>& GetRegisteredExtensionsForTest() const {

return registered_extensions_;