chrome/browser/extensions/api/reading_list_private/reading_list_private_api.h - Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/reading_list_private/reading_list_private_api.h

Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/push_messaging/push_messaging_invalidation_handler.h ('k') | chrome/browser/extensions/api/runtime/chrome_runtime_api_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/reading_list_private/reading_list_private_api.h

diff --git a/chrome/browser/extensions/api/reading_list_private/reading_list_private_api.h b/chrome/browser/extensions/api/reading_list_private/reading_list_private_api.h

index feed7b52086c4f0f109464bf1e0c27d4f64ad7ac..938ad6b78e1d08bc327576b8b4d4ce4e87781be2 100644

--- a/chrome/browser/extensions/api/reading_list_private/reading_list_private_api.h

+++ b/chrome/browser/extensions/api/reading_list_private/reading_list_private_api.h

@@ -21,10 +21,10 @@ class ReadingListPrivateAddEntryFunction : public ChromeAsyncExtensionFunction {

READINGLISTPRIVATE_ADDENTRY)

protected:

- virtual ~ReadingListPrivateAddEntryFunction() {}

+ ~ReadingListPrivateAddEntryFunction() override {}

// ExtensionFunction:

- virtual bool RunAsync() override;

+ bool RunAsync() override;

};

class ReadingListPrivateRemoveEntryFunction

@@ -34,10 +34,10 @@ class ReadingListPrivateRemoveEntryFunction

READINGLISTPRIVATE_REMOVEENTRY)

protected:

- virtual ~ReadingListPrivateRemoveEntryFunction() {}

+ ~ReadingListPrivateRemoveEntryFunction() override {}

// ExtensionFunction:

- virtual bool RunSync() override;

+ bool RunSync() override;

};

class ReadingListPrivateGetEntriesFunction

@@ -47,10 +47,10 @@ class ReadingListPrivateGetEntriesFunction

READINGLISTPRIVATE_GETENTRIES)

protected:

- virtual ~ReadingListPrivateGetEntriesFunction() {}

+ ~ReadingListPrivateGetEntriesFunction() override {}

// ExtensionFunction:

- virtual bool RunSync() override;

+ bool RunSync() override;

};

} // namespace extensions