Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1050)

Unified Diff: chrome/browser/extensions/api/file_system/file_system_api.h

Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/file_system/file_system_api.h
diff --git a/chrome/browser/extensions/api/file_system/file_system_api.h b/chrome/browser/extensions/api/file_system/file_system_api.h
index 62bfa52753e6e71037f80f03764b3ff64fac3e1f..1b7827732b0d70df2538c9aa345fe7ec5cfcea03 100644
--- a/chrome/browser/extensions/api/file_system/file_system_api.h
+++ b/chrome/browser/extensions/api/file_system/file_system_api.h
@@ -40,15 +40,15 @@ class FileSystemGetDisplayPathFunction : public ChromeSyncExtensionFunction {
FILESYSTEM_GETDISPLAYPATH)
protected:
- virtual ~FileSystemGetDisplayPathFunction() {}
- virtual bool RunSync() override;
+ ~FileSystemGetDisplayPathFunction() override {}
+ bool RunSync() override;
};
class FileSystemEntryFunction : public ChromeAsyncExtensionFunction {
protected:
FileSystemEntryFunction();
- virtual ~FileSystemEntryFunction() {}
+ ~FileSystemEntryFunction() override {}
// This is called when writable file entries are being returned. The function
// will ensure the files exist, creating them if necessary, and also check
@@ -88,8 +88,8 @@ class FileSystemGetWritableEntryFunction : public FileSystemEntryFunction {
FILESYSTEM_GETWRITABLEENTRY)
protected:
- virtual ~FileSystemGetWritableEntryFunction() {}
- virtual bool RunAsync() override;
+ ~FileSystemGetWritableEntryFunction() override {}
+ bool RunAsync() override;
private:
void CheckPermissionAndSendResponse();
@@ -105,8 +105,8 @@ class FileSystemIsWritableEntryFunction : public ChromeSyncExtensionFunction {
FILESYSTEM_ISWRITABLEENTRY)
protected:
- virtual ~FileSystemIsWritableEntryFunction() {}
- virtual bool RunSync() override;
+ ~FileSystemIsWritableEntryFunction() override {}
+ bool RunSync() override;
};
class FileSystemChooseEntryFunction : public FileSystemEntryFunction {
@@ -145,8 +145,8 @@ class FileSystemChooseEntryFunction : public FileSystemEntryFunction {
protected:
class FilePicker;
- virtual ~FileSystemChooseEntryFunction() {}
- virtual bool RunAsync() override;
+ ~FileSystemChooseEntryFunction() override {}
+ bool RunAsync() override;
void ShowPicker(const ui::SelectFileDialog::FileTypeInfo& file_type_info,
ui::SelectFileDialog::Type picker_type);
@@ -177,8 +177,8 @@ class FileSystemRetainEntryFunction : public ChromeAsyncExtensionFunction {
DECLARE_EXTENSION_FUNCTION("fileSystem.retainEntry", FILESYSTEM_RETAINENTRY)
protected:
- virtual ~FileSystemRetainEntryFunction() {}
- virtual bool RunAsync() override;
+ ~FileSystemRetainEntryFunction() override {}
+ bool RunAsync() override;
private:
// Retains the file entry referenced by |entry_id| in apps::SavedFilesService.
@@ -195,8 +195,8 @@ class FileSystemIsRestorableFunction : public ChromeSyncExtensionFunction {
DECLARE_EXTENSION_FUNCTION("fileSystem.isRestorable", FILESYSTEM_ISRESTORABLE)
protected:
- virtual ~FileSystemIsRestorableFunction() {}
- virtual bool RunSync() override;
+ ~FileSystemIsRestorableFunction() override {}
+ bool RunSync() override;
};
class FileSystemRestoreEntryFunction : public FileSystemEntryFunction {
@@ -204,8 +204,8 @@ class FileSystemRestoreEntryFunction : public FileSystemEntryFunction {
DECLARE_EXTENSION_FUNCTION("fileSystem.restoreEntry", FILESYSTEM_RESTOREENTRY)
protected:
- virtual ~FileSystemRestoreEntryFunction() {}
- virtual bool RunAsync() override;
+ ~FileSystemRestoreEntryFunction() override {}
+ bool RunAsync() override;
};
class FileSystemObserveDirectoryFunction : public ChromeSyncExtensionFunction {
@@ -214,8 +214,8 @@ class FileSystemObserveDirectoryFunction : public ChromeSyncExtensionFunction {
FILESYSTEM_OBSERVEDIRECTORY)
protected:
- virtual ~FileSystemObserveDirectoryFunction() {}
- virtual bool RunSync() override;
+ ~FileSystemObserveDirectoryFunction() override {}
+ bool RunSync() override;
};
class FileSystemUnobserveEntryFunction : public ChromeSyncExtensionFunction {
@@ -224,8 +224,8 @@ class FileSystemUnobserveEntryFunction : public ChromeSyncExtensionFunction {
FILESYSTEM_UNOBSERVEENTRY)
protected:
- virtual ~FileSystemUnobserveEntryFunction() {}
- virtual bool RunSync() override;
+ ~FileSystemUnobserveEntryFunction() override {}
+ bool RunSync() override;
};
class FileSystemGetObservedEntriesFunction
@@ -235,8 +235,8 @@ class FileSystemGetObservedEntriesFunction
FILESYSTEM_GETOBSERVEDENTRIES);
protected:
- virtual ~FileSystemGetObservedEntriesFunction() {}
- virtual bool RunSync() override;
+ ~FileSystemGetObservedEntriesFunction() override {}
+ bool RunSync() override;
};
} // namespace extensions

Powered by Google App Engine
This is Rietveld 408576698