Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Unified Diff: chrome/browser/extensions/api/file_system/file_system_api.cc

Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/file_system/file_system_api.cc
diff --git a/chrome/browser/extensions/api/file_system/file_system_api.cc b/chrome/browser/extensions/api/file_system/file_system_api.cc
index bbc9b202a1b49bc95e8a8dad1e1e7aec7e8713be..dbe8bfdc83aa506e9c2dc6cabb020662319e8094 100644
--- a/chrome/browser/extensions/api/file_system/file_system_api.cc
+++ b/chrome/browser/extensions/api/file_system/file_system_api.cc
@@ -443,21 +443,21 @@ class FileSystemChooseEntryFunction::FilePicker
NULL);
}
- virtual ~FilePicker() {}
+ ~FilePicker() override {}
private:
// ui::SelectFileDialog::Listener implementation.
- virtual void FileSelected(const base::FilePath& path,
- int index,
- void* params) override {
+ void FileSelected(const base::FilePath& path,
+ int index,
+ void* params) override {
std::vector<base::FilePath> paths;
paths.push_back(path);
MultiFilesSelected(paths, params);
}
- virtual void FileSelectedWithExtraInfo(const ui::SelectedFileInfo& file,
- int index,
- void* params) override {
+ void FileSelectedWithExtraInfo(const ui::SelectedFileInfo& file,
+ int index,
+ void* params) override {
// Normally, file.local_path is used because it is a native path to the
// local read-only cached file in the case of remote file system like
// Chrome OS's Google Drive integration. Here, however, |file.file_path| is
@@ -469,13 +469,13 @@ class FileSystemChooseEntryFunction::FilePicker
FileSelected(file.file_path, index, params);
}
- virtual void MultiFilesSelected(const std::vector<base::FilePath>& files,
- void* params) override {
+ void MultiFilesSelected(const std::vector<base::FilePath>& files,
+ void* params) override {
function_->FilesSelected(files);
delete this;
}
- virtual void MultiFilesSelectedWithExtraInfo(
+ void MultiFilesSelectedWithExtraInfo(
const std::vector<ui::SelectedFileInfo>& files,
void* params) override {
std::vector<base::FilePath> paths;
@@ -486,7 +486,7 @@ class FileSystemChooseEntryFunction::FilePicker
MultiFilesSelected(paths, params);
}
- virtual void FileSelectionCanceled(void* params) override {
+ void FileSelectionCanceled(void* params) override {
function_->FileSelectionCanceled();
delete this;
}

Powered by Google App Engine
This is Rietveld 408576698