Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1742)

Unified Diff: chrome/browser/extensions/external_install_error.h

Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/external_install_error.h
diff --git a/chrome/browser/extensions/external_install_error.h b/chrome/browser/extensions/external_install_error.h
index d56fdf5683b44b0c2ea4e76009dd8c5777a78322..395914e615ae851704b81925e7c0c3eac198a46d 100644
--- a/chrome/browser/extensions/external_install_error.h
+++ b/chrome/browser/extensions/external_install_error.h
@@ -48,11 +48,11 @@ class ExternalInstallError : public ExtensionInstallPrompt::Delegate,
const std::string& extension_id,
AlertType error_type,
ExternalInstallManager* manager);
- virtual ~ExternalInstallError();
+ ~ExternalInstallError() override;
// ExtensionInstallPrompt::Delegate implementation.
- virtual void InstallUIProceed() override;
- virtual void InstallUIAbort(bool user_initiated) override;
+ void InstallUIProceed() override;
+ void InstallUIAbort(bool user_initiated) override;
// Show the associated dialog. This should only be called once the dialog is
// ready.
@@ -66,11 +66,10 @@ class ExternalInstallError : public ExtensionInstallPrompt::Delegate,
private:
// WebstoreDataFetcherDelegate implementation.
- virtual void OnWebstoreRequestFailure() override;
- virtual void OnWebstoreResponseParseSuccess(
+ void OnWebstoreRequestFailure() override;
+ void OnWebstoreResponseParseSuccess(
scoped_ptr<base::DictionaryValue> webstore_data) override;
- virtual void OnWebstoreResponseParseFailure(
- const std::string& error) override;
+ void OnWebstoreResponseParseFailure(const std::string& error) override;
// Called when data fetching has completed (either successfully or not).
void OnFetchComplete();
« no previous file with comments | « chrome/browser/extensions/external_component_loader.h ('k') | chrome/browser/extensions/external_install_error.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698