chrome/browser/extensions/external_component_loader.h - Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/external_component_loader.h

Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_web_ui_override_registrar.h ('k') | chrome/browser/extensions/external_install_error.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/external_component_loader.h

diff --git a/chrome/browser/extensions/external_component_loader.h b/chrome/browser/extensions/external_component_loader.h

index fe9e496ee6d85990c5dc0d5d8376a4acf34fc7b8..3a5d53c9cea3aef364821f6f32c96e66bdb01255 100644

--- a/chrome/browser/extensions/external_component_loader.h

+++ b/chrome/browser/extensions/external_component_loader.h

@@ -29,11 +29,11 @@ class ExternalComponentLoader : public ExternalLoader {

static bool IsModifiable(const extensions::Extension* extension);

protected:

- virtual void StartLoading() override;

+ void StartLoading() override;

private:

friend class base::RefCountedThreadSafe<ExternalLoader>;

- virtual ~ExternalComponentLoader();

+ ~ExternalComponentLoader() override;

// The profile that this loader is associated with. It listens for

// preference changes for that profile.