Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5291)

Unified Diff: chrome/browser/extensions/crx_installer_browsertest.cc

Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/crx_installer_browsertest.cc
diff --git a/chrome/browser/extensions/crx_installer_browsertest.cc b/chrome/browser/extensions/crx_installer_browsertest.cc
index 907d744400a14bf6f13a0c765df0deda72805964..b98d28d3def7789203f1da7e91b83ba342733c21 100644
--- a/chrome/browser/extensions/crx_installer_browsertest.cc
+++ b/chrome/browser/extensions/crx_installer_browsertest.cc
@@ -103,19 +103,17 @@ class MockInstallPrompt : public ExtensionInstallPrompt {
void set_record_oauth2_grant(bool record) { record_oauth2_grant_ = record; }
// Overriding some of the ExtensionInstallUI API.
- virtual void ConfirmInstall(
- Delegate* delegate,
- const Extension* extension,
- const ShowDialogCallback& show_dialog_callback) override {
+ void ConfirmInstall(Delegate* delegate,
+ const Extension* extension,
+ const ShowDialogCallback& show_dialog_callback) override {
proxy_->set_confirmation_requested();
delegate->InstallUIProceed();
}
- virtual void OnInstallSuccess(const Extension* extension,
- SkBitmap* icon) override {
+ void OnInstallSuccess(const Extension* extension, SkBitmap* icon) override {
proxy_->set_extension_id(extension->id());
base::MessageLoopForUI::current()->Quit();
}
- virtual void OnInstallFailure(const CrxInstallerError& error) override {
+ void OnInstallFailure(const CrxInstallerError& error) override {
proxy_->set_error(error.message());
base::MessageLoopForUI::current()->Quit();
}
@@ -149,12 +147,12 @@ class ManagementPolicyMock : public extensions::ManagementPolicy::Provider {
public:
ManagementPolicyMock() {}
- virtual std::string GetDebugPolicyProviderName() const override {
+ std::string GetDebugPolicyProviderName() const override {
return "ManagementPolicyMock";
}
- virtual bool UserMayLoad(const Extension* extension,
- base::string16* error) const override {
+ bool UserMayLoad(const Extension* extension,
+ base::string16* error) const override {
*error = base::UTF8ToUTF16("Dummy error message");
return false;
}
« no previous file with comments | « chrome/browser/extensions/crx_installer.h ('k') | chrome/browser/extensions/declarative_user_script_master.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698