Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5172)

Unified Diff: chrome/browser/extensions/crx_installer.h

Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/crx_installer.h
diff --git a/chrome/browser/extensions/crx_installer.h b/chrome/browser/extensions/crx_installer.h
index 303889be96935f6c92f4623e73e4f379b9426351..bb9083ebd99046c251fc30f2c1e92962645d4353 100644
--- a/chrome/browser/extensions/crx_installer.h
+++ b/chrome/browser/extensions/crx_installer.h
@@ -108,8 +108,8 @@ class CrxInstaller
void InstallWebApp(const WebApplicationInfo& web_app);
// Overridden from ExtensionInstallPrompt::Delegate:
- virtual void InstallUIProceed() override;
- virtual void InstallUIAbort(bool user_initiated) override;
+ void InstallUIProceed() override;
+ void InstallUIAbort(bool user_initiated) override;
int creation_flags() const { return creation_flags_; }
void set_creation_flags(int val) { creation_flags_ = val; }
@@ -209,7 +209,7 @@ class CrxInstaller
CrxInstaller(base::WeakPtr<ExtensionService> service_weak,
scoped_ptr<ExtensionInstallPrompt> client,
const WebstoreInstaller::Approval* approval);
- virtual ~CrxInstaller();
+ ~CrxInstaller() override;
// Converts the source user script to an extension.
void ConvertUserScriptOnFileThread();
@@ -222,12 +222,12 @@ class CrxInstaller
CrxInstallerError AllowInstall(const Extension* extension);
// SandboxedUnpackerClient
- virtual void OnUnpackFailure(const base::string16& error_message) override;
- virtual void OnUnpackSuccess(const base::FilePath& temp_dir,
- const base::FilePath& extension_dir,
- const base::DictionaryValue* original_manifest,
- const Extension* extension,
- const SkBitmap& install_icon) override;
+ void OnUnpackFailure(const base::string16& error_message) override;
+ void OnUnpackSuccess(const base::FilePath& temp_dir,
+ const base::FilePath& extension_dir,
+ const base::DictionaryValue* original_manifest,
+ const Extension* extension,
+ const SkBitmap& install_icon) override;
// Called on the UI thread to start the requirements, policy and blacklist
// checks on the extension.
« no previous file with comments | « chrome/browser/extensions/convert_web_app_browsertest.cc ('k') | chrome/browser/extensions/crx_installer_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698