components/web_modal/popup_manager.h - Issue 666133002: Standardize usage of virtual/override/final in components/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/web_modal/popup_manager.h

Issue 666133002: Standardize usage of virtual/override/final in components/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/web_modal/popup_manager.h

diff --git a/components/web_modal/popup_manager.h b/components/web_modal/popup_manager.h

index 0ce4a583f1045691d7d80c94d6028aae2cae46d9..9d0c9fb7216e3af5bdb04295be6be9f7815a09fe 100644

--- a/components/web_modal/popup_manager.h

+++ b/components/web_modal/popup_manager.h

@@ -27,7 +27,7 @@ class PopupManager : public SinglePopupManagerDelegate {

// |host| may be null.

PopupManager(WebContentsModalDialogHost* host);

- virtual ~PopupManager();

+ ~PopupManager() override;

// Returns the native view which will be the parent of managed popups.

virtual gfx::NativeView GetHostView() const;

@@ -48,7 +48,7 @@ class PopupManager : public SinglePopupManagerDelegate {

const content::WebContents* web_contents) const;

// Called when a NativePopup we own is about to be closed.

- virtual void WillClose(NativePopup popup) override;

+ void WillClose(NativePopup popup) override;

// Called by views code to re-activate popups anchored to a particular tab

// when that tab gets focus. Note that depending on the situation, more than

« no previous file with comments | « components/web_cache/renderer/web_cache_render_process_observer.h ('k') | components/web_modal/popup_manager.cc » ('j') | no next file with comments »