components/web_modal/popup_manager.cc - Issue 666133002: Standardize usage of virtual/override/final in components/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/web_modal/popup_manager.cc

Issue 666133002: Standardize usage of virtual/override/final in components/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/web_modal/popup_manager.cc

diff --git a/components/web_modal/popup_manager.cc b/components/web_modal/popup_manager.cc

index 215d4b8efa2fbcde4cefaa988576e5dc284464f1..4d073658d387e3a691f2ca4661081178c3f51429 100644

--- a/components/web_modal/popup_manager.cc

+++ b/components/web_modal/popup_manager.cc

@@ -26,7 +26,7 @@ class PopupManagerRelay : public content::WebContentsUserData<PopupManager> {

explicit PopupManagerRelay(base::WeakPtr<PopupManager> manager)

: manager_(manager) {}

- virtual ~PopupManagerRelay() {}

+ ~PopupManagerRelay() override {}

base::WeakPtr<PopupManager> manager_;

};

« no previous file with comments | « components/web_modal/popup_manager.h ('k') | components/web_modal/test_web_contents_modal_dialog_host.h » ('j') | no next file with comments »