components/policy/core/common/cloud/policy_header_service.h - Issue 666133002: Standardize usage of virtual/override/final in components/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/policy/core/common/cloud/policy_header_service.h

Issue 666133002: Standardize usage of virtual/override/final in components/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/policy/core/common/cloud/mock_device_management_service.cc ('k') | components/policy/core/common/cloud/system_policy_request_context.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/policy/core/common/cloud/policy_header_service.h

diff --git a/components/policy/core/common/cloud/policy_header_service.h b/components/policy/core/common/cloud/policy_header_service.h

index c7865339884867e7a02bf26694f639f56e5bb9d3..f0bc4a99893ddf11489e870332448be49af2183c 100644

--- a/components/policy/core/common/cloud/policy_header_service.h

+++ b/components/policy/core/common/cloud/policy_header_service.h

@@ -33,7 +33,7 @@ class POLICY_EXPORT PolicyHeaderService : public CloudPolicyStore::Observer {

const std::string& verification_key_hash,

CloudPolicyStore* user_policy_store,

CloudPolicyStore* device_policy_store);

- virtual ~PolicyHeaderService();

+ ~PolicyHeaderService() override;

// Creates a PolicyHeaderIOHelper object to be run on the IO thread and

// add policy headers to outgoing requests. The caller takes ownership of

@@ -44,8 +44,8 @@ class POLICY_EXPORT PolicyHeaderService : public CloudPolicyStore::Observer {

scoped_refptr<base::SequencedTaskRunner> task_runner);

// Overridden CloudPolicyStore::Observer methods:

- virtual void OnStoreLoaded(CloudPolicyStore* store) override;

- virtual void OnStoreError(CloudPolicyStore* store) override;

+ void OnStoreLoaded(CloudPolicyStore* store) override;

+ void OnStoreError(CloudPolicyStore* store) override;

// Returns a list of all PolicyHeaderIOHelpers created by this object.

std::vector<PolicyHeaderIOHelper*> GetHelpersForTest();