Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Unified Diff: components/policy/core/common/cloud/mock_device_management_service.cc

Issue 666133002: Standardize usage of virtual/override/final in components/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/policy/core/common/cloud/mock_device_management_service.cc
diff --git a/components/policy/core/common/cloud/mock_device_management_service.cc b/components/policy/core/common/cloud/mock_device_management_service.cc
index b8c042129119c5dc0747bc1996e41bacc00771fd..970dd01bf7c4ba9670bd198821d8c56e93423627 100644
--- a/components/policy/core/common/cloud/mock_device_management_service.cc
+++ b/components/policy/core/common/cloud/mock_device_management_service.cc
@@ -26,10 +26,10 @@ class MockRequestJobBase : public DeviceManagementRequestJob {
MockDeviceManagementService* service)
: DeviceManagementRequestJob(type, std::string(), std::string()),
service_(service) {}
- virtual ~MockRequestJobBase() {}
+ ~MockRequestJobBase() override {}
protected:
- virtual void Run() override {
+ void Run() override {
service_->StartJob(ExtractParameter(dm_protocol::kParamRequest),
gaia_token_,
ExtractParameter(dm_protocol::kParamOAuthToken),
@@ -67,10 +67,10 @@ class SyncRequestJob : public MockRequestJobBase {
: MockRequestJobBase(type, service),
status_(status),
response_(response) {}
- virtual ~SyncRequestJob() {}
+ ~SyncRequestJob() override {}
protected:
- virtual void Run() override {
+ void Run() override {
MockRequestJobBase::Run();
callback_.Run(status_, net::OK, response_);
}
@@ -88,18 +88,17 @@ class AsyncRequestJob : public MockRequestJobBase,
public:
AsyncRequestJob(JobType type, MockDeviceManagementService* service)
: MockRequestJobBase(type, service) {}
- virtual ~AsyncRequestJob() {}
+ ~AsyncRequestJob() override {}
protected:
- virtual void RetryJob() override {
+ void RetryJob() override {
if (!retry_callback_.is_null())
retry_callback_.Run(this);
Run();
}
- virtual void SendResponse(
- DeviceManagementStatus status,
- const em::DeviceManagementResponse& response) override {
+ void SendResponse(DeviceManagementStatus status,
+ const em::DeviceManagementResponse& response) override {
callback_.Run(status, net::OK, response);
}

Powered by Google App Engine
This is Rietveld 408576698