components/policy/core/common/cloud/external_policy_data_fetcher.h - Issue 666133002: Standardize usage of virtual/override/final in components/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/policy/core/common/cloud/external_policy_data_fetcher.h

Issue 666133002: Standardize usage of virtual/override/final in components/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/policy/core/common/cloud/device_management_service.cc ('k') | components/policy/core/common/cloud/mock_device_management_service.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/policy/core/common/cloud/external_policy_data_fetcher.h

diff --git a/components/policy/core/common/cloud/external_policy_data_fetcher.h b/components/policy/core/common/cloud/external_policy_data_fetcher.h

index 5f9fc456168947eb48734b07dc2890e5a7fd79eb..b4927683ddbca8e9500b22c13c922a5486762e0a 100644

--- a/components/policy/core/common/cloud/external_policy_data_fetcher.h

+++ b/components/policy/core/common/cloud/external_policy_data_fetcher.h

@@ -139,7 +139,7 @@ class POLICY_EXPORT ExternalPolicyDataFetcherBackend

ExternalPolicyDataFetcherBackend(

scoped_refptr<base::SequencedTaskRunner> io_task_runner,

scoped_refptr<net::URLRequestContextGetter> request_context);

- virtual ~ExternalPolicyDataFetcherBackend();

+ ~ExternalPolicyDataFetcherBackend() override;

// Create an ExternalPolicyDataFetcher that allows fetch jobs to be started

// from the thread represented by |task_runner|.

@@ -156,10 +156,10 @@ class POLICY_EXPORT ExternalPolicyDataFetcherBackend

const base::Closure& callback);

// net::URLFetcherDelegate:

- virtual void OnURLFetchComplete(const net::URLFetcher* source) override;

- virtual void OnURLFetchDownloadProgress(const net::URLFetcher* source,

- int64 current,

- int64 total) override;

+ void OnURLFetchComplete(const net::URLFetcher* source) override;

+ void OnURLFetchDownloadProgress(const net::URLFetcher* source,

+ int64 current,

+ int64 total) override;

private:

scoped_refptr<base::SequencedTaskRunner> io_task_runner_;