components/policy/core/common/cloud/device_management_service.cc - Issue 666133002: Standardize usage of virtual/override/final in components/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/policy/core/common/cloud/device_management_service.cc

Issue 666133002: Standardize usage of virtual/override/final in components/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/policy/core/common/cloud/device_management_service.h ('k') | components/policy/core/common/cloud/external_policy_data_fetcher.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/policy/core/common/cloud/device_management_service.cc

diff --git a/components/policy/core/common/cloud/device_management_service.cc b/components/policy/core/common/cloud/device_management_service.cc

index b05cda75a2b61a015f03fb2818095c5c81dbff76..50aa706b05bcacb4db2c2a4264f74363d6743a14 100644

--- a/components/policy/core/common/cloud/device_management_service.cc

+++ b/components/policy/core/common/cloud/device_management_service.cc

@@ -142,7 +142,7 @@ class DeviceManagementRequestJobImpl : public DeviceManagementRequestJob {

const std::string& platform_parameter,

DeviceManagementService* service,

const scoped_refptr<net::URLRequestContextGetter>& request_context);

- virtual ~DeviceManagementRequestJobImpl();

+ ~DeviceManagementRequestJobImpl() override;

// Handles the URL request response.

void HandleResponse(const net::URLRequestStatus& status,

@@ -166,7 +166,7 @@ class DeviceManagementRequestJobImpl : public DeviceManagementRequestJob {

protected:

// DeviceManagementRequestJob:

- virtual void Run() override;

+ void Run() override;

private:

// Invokes the callback with the given error code.