components/policy/core/common/cloud/cloud_policy_service.h - Issue 666133002: Standardize usage of virtual/override/final in components/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/policy/core/common/cloud/cloud_policy_service.h

Issue 666133002: Standardize usage of virtual/override/final in components/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/policy/core/common/cloud/cloud_policy_refresh_scheduler.h ('k') | components/policy/core/common/cloud/component_cloud_policy_service.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/policy/core/common/cloud/cloud_policy_service.h

diff --git a/components/policy/core/common/cloud/cloud_policy_service.h b/components/policy/core/common/cloud/cloud_policy_service.h

index 3a68fd9db70ec1d4a745df9d6455aa6aa9ebb077..efcbb3f6239d4f01ecc751eb1c284e75c4b6b856 100644

--- a/components/policy/core/common/cloud/cloud_policy_service.h

+++ b/components/policy/core/common/cloud/cloud_policy_service.h

@@ -42,7 +42,7 @@ class POLICY_EXPORT CloudPolicyService : public CloudPolicyClient::Observer,

CloudPolicyService(const PolicyNamespaceKey& policy_ns_key,

CloudPolicyClient* client,

CloudPolicyStore* store);

- virtual ~CloudPolicyService();

+ ~CloudPolicyService() override;

// Returns the domain that manages this user/device, according to the current

// policy blob. Empty if not managed/not available.

@@ -57,13 +57,13 @@ class POLICY_EXPORT CloudPolicyService : public CloudPolicyClient::Observer,

void RemoveObserver(Observer* observer);

// CloudPolicyClient::Observer:

- virtual void OnPolicyFetched(CloudPolicyClient* client) override;

- virtual void OnRegistrationStateChanged(CloudPolicyClient* client) override;

- virtual void OnClientError(CloudPolicyClient* client) override;

+ void OnPolicyFetched(CloudPolicyClient* client) override;

+ void OnRegistrationStateChanged(CloudPolicyClient* client) override;

+ void OnClientError(CloudPolicyClient* client) override;

// CloudPolicyStore::Observer:

- virtual void OnStoreLoaded(CloudPolicyStore* store) override;

- virtual void OnStoreError(CloudPolicyStore* store) override;

+ void OnStoreLoaded(CloudPolicyStore* store) override;

+ void OnStoreError(CloudPolicyStore* store) override;

bool IsInitializationComplete() const { return initialization_complete_; }