components/policy/core/common/cloud/cloud_policy_refresh_scheduler.h - Issue 666133002: Standardize usage of virtual/override/final in components/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/policy/core/common/cloud/cloud_policy_refresh_scheduler.h

Issue 666133002: Standardize usage of virtual/override/final in components/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/policy/core/common/cloud/cloud_policy_manager_unittest.cc ('k') | components/policy/core/common/cloud/cloud_policy_service.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/policy/core/common/cloud/cloud_policy_refresh_scheduler.h

diff --git a/components/policy/core/common/cloud/cloud_policy_refresh_scheduler.h b/components/policy/core/common/cloud/cloud_policy_refresh_scheduler.h

index 0febc4827c129d3ba0f6f8d01e9fa4cda480471d..9a1eb7521e3c6da9c69aebd6b21b122a6917e2f7 100644

--- a/components/policy/core/common/cloud/cloud_policy_refresh_scheduler.h

+++ b/components/policy/core/common/cloud/cloud_policy_refresh_scheduler.h

@@ -43,7 +43,7 @@ class POLICY_EXPORT CloudPolicyRefreshScheduler

CloudPolicyClient* client,

CloudPolicyStore* store,

const scoped_refptr<base::SequencedTaskRunner>& task_runner);

- virtual ~CloudPolicyRefreshScheduler();

+ ~CloudPolicyRefreshScheduler() override;

base::Time last_refresh() const { return last_refresh_; }

int64 refresh_delay() const { return refresh_delay_ms_; }

@@ -68,16 +68,16 @@ class POLICY_EXPORT CloudPolicyRefreshScheduler

}

// CloudPolicyClient::Observer:

- virtual void OnPolicyFetched(CloudPolicyClient* client) override;

- virtual void OnRegistrationStateChanged(CloudPolicyClient* client) override;

- virtual void OnClientError(CloudPolicyClient* client) override;

+ void OnPolicyFetched(CloudPolicyClient* client) override;

+ void OnRegistrationStateChanged(CloudPolicyClient* client) override;

+ void OnClientError(CloudPolicyClient* client) override;

// CloudPolicyStore::Observer:

- virtual void OnStoreLoaded(CloudPolicyStore* store) override;

- virtual void OnStoreError(CloudPolicyStore* store) override;

+ void OnStoreLoaded(CloudPolicyStore* store) override;

+ void OnStoreError(CloudPolicyStore* store) override;

// net::NetworkChangeNotifier::IPAddressObserver:

- virtual void OnIPAddressChanged() override;

+ void OnIPAddressChanged() override;

private:

// Initializes |last_refresh_| to the policy timestamp from |store_| in case