components/policy/core/common/cloud/cloud_policy_client_registration_helper.h - Issue 666133002: Standardize usage of virtual/override/final in components/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/policy/core/common/cloud/cloud_policy_client_registration_helper.h

Issue 666133002: Standardize usage of virtual/override/final in components/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/policy/core/common/async_policy_provider.h ('k') | components/policy/core/common/cloud/cloud_policy_client_registration_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/policy/core/common/cloud/cloud_policy_client_registration_helper.h

diff --git a/components/policy/core/common/cloud/cloud_policy_client_registration_helper.h b/components/policy/core/common/cloud/cloud_policy_client_registration_helper.h

index 26d8b539df436351d16f18e2d21e325c60ff0d6c..9b7e464b46778baa5ac08b0d6f7128bfb7f50d44 100644

--- a/components/policy/core/common/cloud/cloud_policy_client_registration_helper.h

+++ b/components/policy/core/common/cloud/cloud_policy_client_registration_helper.h

@@ -37,7 +37,7 @@ class POLICY_EXPORT CloudPolicyClientRegistrationHelper

CloudPolicyClientRegistrationHelper(

CloudPolicyClient* client,

enterprise_management::DeviceRegisterRequest::Type registration_type);

- virtual ~CloudPolicyClientRegistrationHelper();

+ ~CloudPolicyClientRegistrationHelper() override;

// Starts the client registration process. This version uses the

// supplied OAuth2TokenService to mint the new token for the userinfo

@@ -74,15 +74,13 @@ class POLICY_EXPORT CloudPolicyClientRegistrationHelper

void OnTokenFetched(const std::string& oauth_access_token);

// UserInfoFetcher::Delegate implementation:

- virtual void OnGetUserInfoSuccess(

- const base::DictionaryValue* response) override;

- virtual void OnGetUserInfoFailure(

- const GoogleServiceAuthError& error) override;

+ void OnGetUserInfoSuccess(const base::DictionaryValue* response) override;

+ void OnGetUserInfoFailure(const GoogleServiceAuthError& error) override;

// CloudPolicyClient::Observer implementation:

- virtual void OnPolicyFetched(CloudPolicyClient* client) override;

- virtual void OnRegistrationStateChanged(CloudPolicyClient* client) override;

- virtual void OnClientError(CloudPolicyClient* client) override;

+ void OnPolicyFetched(CloudPolicyClient* client) override;

+ void OnRegistrationStateChanged(CloudPolicyClient* client) override;

+ void OnClientError(CloudPolicyClient* client) override;

// Invoked when the registration request has been completed.

void RequestCompleted();