components/policy/core/common/cloud/cloud_policy_client_registration_helper.cc - Issue 666133002: Standardize usage of virtual/override/final in components/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/policy/core/common/cloud/cloud_policy_client_registration_helper.cc

Issue 666133002: Standardize usage of virtual/override/final in components/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/policy/core/common/cloud/cloud_policy_client_registration_helper.h ('k') | components/policy/core/common/cloud/cloud_policy_core_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/policy/core/common/cloud/cloud_policy_client_registration_helper.cc

diff --git a/components/policy/core/common/cloud/cloud_policy_client_registration_helper.cc b/components/policy/core/common/cloud/cloud_policy_client_registration_helper.cc

index 46ddb17571a5214ecd1bb5bbc68f254bc16b8e0b..9a5b103691ffd4c50dcd0750d9d79008c10c0a71 100644

--- a/components/policy/core/common/cloud/cloud_policy_client_registration_helper.cc

+++ b/components/policy/core/common/cloud/cloud_policy_client_registration_helper.cc

@@ -44,11 +44,11 @@ class CloudPolicyClientRegistrationHelper::TokenServiceHelper

private:

// OAuth2TokenService::Consumer implementation:

- virtual void OnGetTokenSuccess(const OAuth2TokenService::Request* request,

- const std::string& access_token,

- const base::Time& expiration_time) override;

- virtual void OnGetTokenFailure(const OAuth2TokenService::Request* request,

- const GoogleServiceAuthError& error) override;

+ void OnGetTokenSuccess(const OAuth2TokenService::Request* request,

+ const std::string& access_token,

+ const base::Time& expiration_time) override;

+ void OnGetTokenFailure(const OAuth2TokenService::Request* request,

+ const GoogleServiceAuthError& error) override;

StringCallback callback_;

scoped_ptr<OAuth2TokenService::Request> token_request_;

@@ -107,10 +107,9 @@ class CloudPolicyClientRegistrationHelper::LoginTokenHelper

private:

// OAuth2AccessTokenConsumer implementation:

- virtual void OnGetTokenSuccess(const std::string& access_token,

- const base::Time& expiration_time) override;

- virtual void OnGetTokenFailure(

- const GoogleServiceAuthError& error) override;

+ void OnGetTokenSuccess(const std::string& access_token,

+ const base::Time& expiration_time) override;

+ void OnGetTokenFailure(const GoogleServiceAuthError& error) override;

StringCallback callback_;

scoped_ptr<OAuth2AccessTokenFetcher> oauth2_access_token_fetcher_;