components/plugins/renderer/plugin_placeholder.h - Issue 666133002: Standardize usage of virtual/override/final in components/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/plugins/renderer/plugin_placeholder.h

Issue 666133002: Standardize usage of virtual/override/final in components/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/plugins/renderer/mobile_youtube_plugin.h ('k') | components/policy/core/browser/autofill_policy_handler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/plugins/renderer/plugin_placeholder.h

diff --git a/components/plugins/renderer/plugin_placeholder.h b/components/plugins/renderer/plugin_placeholder.h

index 2d3733ff820cb116129748b7efcf534dbec96721..a5f25648e6e27842f76e67311cb65f4382a0df4a 100644

--- a/components/plugins/renderer/plugin_placeholder.h

+++ b/components/plugins/renderer/plugin_placeholder.h

@@ -43,7 +43,7 @@ class PluginPlaceholder : public content::RenderFrameObserver,

const std::string& html_data,

GURL placeholderDataUrl);

- virtual ~PluginPlaceholder();

+ ~PluginPlaceholder() override;

void OnLoadBlockedPlugins(const std::string& identifier);

void OnSetIsPrerendering(bool is_prerendering);

@@ -67,16 +67,16 @@ class PluginPlaceholder : public content::RenderFrameObserver,

void LoadPlugin();

// gin::Wrappable method:

- virtual gin::ObjectTemplateBuilder GetObjectTemplateBuilder(

+ gin::ObjectTemplateBuilder GetObjectTemplateBuilder(

v8::Isolate* isolate) override;

private:

// WebViewPlugin::Delegate methods:

- virtual void ShowContextMenu(const blink::WebMouseEvent&) override;

- virtual void PluginDestroyed() override;

+ void ShowContextMenu(const blink::WebMouseEvent&) override;

+ void PluginDestroyed() override;

// RenderFrameObserver methods:

- virtual void OnDestruct() override;

+ void OnDestruct() override;

// Javascript callbacks:

« no previous file with comments | « components/plugins/renderer/mobile_youtube_plugin.h ('k') | components/policy/core/browser/autofill_policy_handler.h » ('j') | no next file with comments »