components/plugins/renderer/mobile_youtube_plugin.h - Issue 666133002: Standardize usage of virtual/override/final in components/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/plugins/renderer/mobile_youtube_plugin.h

Issue 666133002: Standardize usage of virtual/override/final in components/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/password_manager/core/browser/webdata/logins_table.h ('k') | components/plugins/renderer/plugin_placeholder.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/plugins/renderer/mobile_youtube_plugin.h

diff --git a/components/plugins/renderer/mobile_youtube_plugin.h b/components/plugins/renderer/mobile_youtube_plugin.h

index 9e6827744035d4b6df21ebb2b0a09148e6e3cd52..99a6213b654975785eb21acd04e0af5867e6b689 100644

--- a/components/plugins/renderer/mobile_youtube_plugin.h

+++ b/components/plugins/renderer/mobile_youtube_plugin.h

@@ -26,16 +26,16 @@ class MobileYouTubePlugin : public PluginPlaceholder {

static bool IsYouTubeURL(const GURL& url, const std::string& mime_type);

private:

- virtual ~MobileYouTubePlugin();

+ ~MobileYouTubePlugin() override;

// Opens a youtube app in the current tab.

void OpenYoutubeUrlCallback();

// WebViewPlugin::Delegate (via PluginPlaceholder) method

- virtual void BindWebFrame(blink::WebFrame* frame) override;

+ void BindWebFrame(blink::WebFrame* frame) override;

// gin::Wrappable (via PluginPlaceholder) method

- virtual gin::ObjectTemplateBuilder GetObjectTemplateBuilder(

+ gin::ObjectTemplateBuilder GetObjectTemplateBuilder(

v8::Isolate* isolate) override;

DISALLOW_COPY_AND_ASSIGN(MobileYouTubePlugin);