components/navigation_interception/intercept_navigation_resource_throttle_unittest.cc - Issue 666133002: Standardize usage of virtual/override/final in components/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/navigation_interception/intercept_navigation_resource_throttle_unittest.cc

Issue 666133002: Standardize usage of virtual/override/final in components/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/navigation_interception/intercept_navigation_resource_throttle.h ('k') | components/network_time/network_time_tracker_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/navigation_interception/intercept_navigation_resource_throttle_unittest.cc

diff --git a/components/navigation_interception/intercept_navigation_resource_throttle_unittest.cc b/components/navigation_interception/intercept_navigation_resource_throttle_unittest.cc

index b39078edbf7fb920edcc3a5c44883214216e71d6..a55cda34bbc2c627f3b4c86badc77d227d0cbf82 100644

--- a/components/navigation_interception/intercept_navigation_resource_throttle_unittest.cc

+++ b/components/navigation_interception/intercept_navigation_resource_throttle_unittest.cc

@@ -86,16 +86,10 @@ class MockResourceController : public content::ResourceController {

Status status() const { return status_; }

// ResourceController:

- virtual void Cancel() override {

- NOTREACHED();

- }

- virtual void CancelAndIgnore() override {

- status_ = CANCELLED;

- }

- virtual void CancelWithError(int error_code) override {

- NOTREACHED();

- }

- virtual void Resume() override {

+ void Cancel() override { NOTREACHED(); }

+ void CancelAndIgnore() override { status_ = CANCELLED; }

+ void CancelWithError(int error_code) override { NOTREACHED(); }

+ void Resume() override {

DCHECK(status_ == UNKNOWN);

status_ = RESUMED;

}