components/navigation_interception/intercept_navigation_resource_throttle.h - Issue 666133002: Standardize usage of virtual/override/final in components/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/navigation_interception/intercept_navigation_resource_throttle.h

Issue 666133002: Standardize usage of virtual/override/final in components/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/nacl/renderer/trusted_plugin_channel.h ('k') | components/navigation_interception/intercept_navigation_resource_throttle_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/navigation_interception/intercept_navigation_resource_throttle.h

diff --git a/components/navigation_interception/intercept_navigation_resource_throttle.h b/components/navigation_interception/intercept_navigation_resource_throttle.h

index b77a5f756288304464c9148d65b3996c51b5b8c7..062a05f77f3033c33b2d15b2731761e67bb56bd9 100644

--- a/components/navigation_interception/intercept_navigation_resource_throttle.h

+++ b/components/navigation_interception/intercept_navigation_resource_throttle.h

@@ -37,12 +37,12 @@ class InterceptNavigationResourceThrottle : public content::ResourceThrottle {

InterceptNavigationResourceThrottle(

net::URLRequest* request,

CheckOnUIThreadCallback should_ignore_callback);

- virtual ~InterceptNavigationResourceThrottle();

+ ~InterceptNavigationResourceThrottle() override;

// content::ResourceThrottle implementation:

- virtual void WillStartRequest(bool* defer) override;

- virtual void WillRedirectRequest(const GURL& new_url, bool* defer) override;

- virtual const char* GetNameForLogging() const override;

+ void WillStartRequest(bool* defer) override;

+ void WillRedirectRequest(const GURL& new_url, bool* defer) override;

+ const char* GetNameForLogging() const override;

private:

std::string GetMethodAfterRedirect();