Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Unified Diff: components/invalidation/registration_manager_unittest.cc

Issue 666133002: Standardize usage of virtual/override/final in components/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/invalidation/registration_manager_unittest.cc
diff --git a/components/invalidation/registration_manager_unittest.cc b/components/invalidation/registration_manager_unittest.cc
index 30e58653ef05e40ebe65b611a63f4d404d595e56..c7bd7298e8bb8cd4d11d1298ce0c2792e61bb893 100644
--- a/components/invalidation/registration_manager_unittest.cc
+++ b/components/invalidation/registration_manager_unittest.cc
@@ -28,16 +28,14 @@ class FakeRegistrationManager : public RegistrationManager {
: RegistrationManager(invalidation_client),
jitter_(0.0) {}
- virtual ~FakeRegistrationManager() {}
+ ~FakeRegistrationManager() override {}
void SetJitter(double jitter) {
jitter_ = jitter;
}
protected:
- virtual double GetJitter() override {
- return jitter_;
- }
+ double GetJitter() override { return jitter_; }
private:
double jitter_;
@@ -51,7 +49,7 @@ class FakeInvalidationClient : public invalidation::InvalidationClient {
public:
FakeInvalidationClient() {}
- virtual ~FakeInvalidationClient() {}
+ ~FakeInvalidationClient() override {}
void LoseRegistration(const invalidation::ObjectId& oid) {
EXPECT_TRUE(ContainsKey(registered_ids_, oid));
@@ -64,27 +62,25 @@ class FakeInvalidationClient : public invalidation::InvalidationClient {
// invalidation::InvalidationClient implementation.
- virtual void Start() override {}
- virtual void Stop() override {}
- virtual void Acknowledge(const invalidation::AckHandle& handle) override {}
+ void Start() override {}
+ void Stop() override {}
+ void Acknowledge(const invalidation::AckHandle& handle) override {}
- virtual void Register(const invalidation::ObjectId& oid) override {
+ void Register(const invalidation::ObjectId& oid) override {
EXPECT_FALSE(ContainsKey(registered_ids_, oid));
registered_ids_.insert(oid);
}
- virtual void Register(
- const std::vector<invalidation::ObjectId>& oids) override {
+ void Register(const std::vector<invalidation::ObjectId>& oids) override {
// Unused for now.
}
- virtual void Unregister(const invalidation::ObjectId& oid) override {
+ void Unregister(const invalidation::ObjectId& oid) override {
EXPECT_TRUE(ContainsKey(registered_ids_, oid));
registered_ids_.erase(oid);
}
- virtual void Unregister(
- const std::vector<invalidation::ObjectId>& oids) override {
+ void Unregister(const std::vector<invalidation::ObjectId>& oids) override {
// Unused for now.
}
« no previous file with comments | « components/invalidation/push_client_channel_unittest.cc ('k') | components/invalidation/sync_invalidation_listener.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698