Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Side by Side Diff: components/invalidation/registration_manager_unittest.cc

Issue 666133002: Standardize usage of virtual/override/final in components/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/invalidation/registration_manager.h" 5 #include "components/invalidation/registration_manager.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <cmath> 8 #include <cmath>
9 #include <cstddef> 9 #include <cstddef>
10 #include <deque> 10 #include <deque>
(...skipping 10 matching lines...) Expand all
21 namespace { 21 namespace {
22 22
23 // Fake registration manager that lets you override jitter. 23 // Fake registration manager that lets you override jitter.
24 class FakeRegistrationManager : public RegistrationManager { 24 class FakeRegistrationManager : public RegistrationManager {
25 public: 25 public:
26 explicit FakeRegistrationManager( 26 explicit FakeRegistrationManager(
27 invalidation::InvalidationClient* invalidation_client) 27 invalidation::InvalidationClient* invalidation_client)
28 : RegistrationManager(invalidation_client), 28 : RegistrationManager(invalidation_client),
29 jitter_(0.0) {} 29 jitter_(0.0) {}
30 30
31 virtual ~FakeRegistrationManager() {} 31 ~FakeRegistrationManager() override {}
32 32
33 void SetJitter(double jitter) { 33 void SetJitter(double jitter) {
34 jitter_ = jitter; 34 jitter_ = jitter;
35 } 35 }
36 36
37 protected: 37 protected:
38 virtual double GetJitter() override { 38 double GetJitter() override { return jitter_; }
39 return jitter_;
40 }
41 39
42 private: 40 private:
43 double jitter_; 41 double jitter_;
44 42
45 DISALLOW_COPY_AND_ASSIGN(FakeRegistrationManager); 43 DISALLOW_COPY_AND_ASSIGN(FakeRegistrationManager);
46 }; 44 };
47 45
48 // Fake invalidation client that just stores the currently-registered 46 // Fake invalidation client that just stores the currently-registered
49 // object IDs. 47 // object IDs.
50 class FakeInvalidationClient : public invalidation::InvalidationClient { 48 class FakeInvalidationClient : public invalidation::InvalidationClient {
51 public: 49 public:
52 FakeInvalidationClient() {} 50 FakeInvalidationClient() {}
53 51
54 virtual ~FakeInvalidationClient() {} 52 ~FakeInvalidationClient() override {}
55 53
56 void LoseRegistration(const invalidation::ObjectId& oid) { 54 void LoseRegistration(const invalidation::ObjectId& oid) {
57 EXPECT_TRUE(ContainsKey(registered_ids_, oid)); 55 EXPECT_TRUE(ContainsKey(registered_ids_, oid));
58 registered_ids_.erase(oid); 56 registered_ids_.erase(oid);
59 } 57 }
60 58
61 void LoseAllRegistrations() { 59 void LoseAllRegistrations() {
62 registered_ids_.clear(); 60 registered_ids_.clear();
63 } 61 }
64 62
65 // invalidation::InvalidationClient implementation. 63 // invalidation::InvalidationClient implementation.
66 64
67 virtual void Start() override {} 65 void Start() override {}
68 virtual void Stop() override {} 66 void Stop() override {}
69 virtual void Acknowledge(const invalidation::AckHandle& handle) override {} 67 void Acknowledge(const invalidation::AckHandle& handle) override {}
70 68
71 virtual void Register(const invalidation::ObjectId& oid) override { 69 void Register(const invalidation::ObjectId& oid) override {
72 EXPECT_FALSE(ContainsKey(registered_ids_, oid)); 70 EXPECT_FALSE(ContainsKey(registered_ids_, oid));
73 registered_ids_.insert(oid); 71 registered_ids_.insert(oid);
74 } 72 }
75 73
76 virtual void Register( 74 void Register(const std::vector<invalidation::ObjectId>& oids) override {
77 const std::vector<invalidation::ObjectId>& oids) override {
78 // Unused for now. 75 // Unused for now.
79 } 76 }
80 77
81 virtual void Unregister(const invalidation::ObjectId& oid) override { 78 void Unregister(const invalidation::ObjectId& oid) override {
82 EXPECT_TRUE(ContainsKey(registered_ids_, oid)); 79 EXPECT_TRUE(ContainsKey(registered_ids_, oid));
83 registered_ids_.erase(oid); 80 registered_ids_.erase(oid);
84 } 81 }
85 82
86 virtual void Unregister( 83 void Unregister(const std::vector<invalidation::ObjectId>& oids) override {
87 const std::vector<invalidation::ObjectId>& oids) override {
88 // Unused for now. 84 // Unused for now.
89 } 85 }
90 86
91 const ObjectIdSet& GetRegisteredIdsForTest() const { 87 const ObjectIdSet& GetRegisteredIdsForTest() const {
92 return registered_ids_; 88 return registered_ids_;
93 } 89 }
94 90
95 private: 91 private:
96 ObjectIdSet registered_ids_; 92 ObjectIdSet registered_ids_;
97 93
(...skipping 326 matching lines...) Expand 10 before | Expand all | Expand 10 after
424 fake_registration_manager_.GetPendingRegistrationsForTest()); 420 fake_registration_manager_.GetPendingRegistrationsForTest());
425 421
426 fake_registration_manager_.MarkAllRegistrationsLost(); 422 fake_registration_manager_.MarkAllRegistrationsLost();
427 ExpectPendingRegistrations( 423 ExpectPendingRegistrations(
428 enabled_ids, 0.0, 424 enabled_ids, 0.0,
429 fake_registration_manager_.GetPendingRegistrationsForTest()); 425 fake_registration_manager_.GetPendingRegistrationsForTest());
430 } 426 }
431 427
432 } // namespace 428 } // namespace
433 } // namespace syncer 429 } // namespace syncer
OLDNEW
« no previous file with comments | « components/invalidation/push_client_channel_unittest.cc ('k') | components/invalidation/sync_invalidation_listener.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698