Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(436)

Unified Diff: components/gcm_driver/default_gcm_app_handler.h

Issue 666133002: Standardize usage of virtual/override/final in components/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/feedback/feedback_uploader_factory.h ('k') | components/gcm_driver/fake_gcm_app_handler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/gcm_driver/default_gcm_app_handler.h
diff --git a/components/gcm_driver/default_gcm_app_handler.h b/components/gcm_driver/default_gcm_app_handler.h
index ffe382b2fe4b52c7e4976a8c1b17b96a6720f954..bfe76a11d087f60aaf9138d6198fcbc4e9030aca 100644
--- a/components/gcm_driver/default_gcm_app_handler.h
+++ b/components/gcm_driver/default_gcm_app_handler.h
@@ -15,18 +15,18 @@ namespace gcm {
class DefaultGCMAppHandler : public GCMAppHandler {
public:
DefaultGCMAppHandler();
- virtual ~DefaultGCMAppHandler();
+ ~DefaultGCMAppHandler() override;
// Overridden from GCMAppHandler:
- virtual void ShutdownHandler() override;
- virtual void OnMessage(const std::string& app_id,
- const GCMClient::IncomingMessage& message) override;
- virtual void OnMessagesDeleted(const std::string& app_id) override;
- virtual void OnSendError(
+ void ShutdownHandler() override;
+ void OnMessage(const std::string& app_id,
+ const GCMClient::IncomingMessage& message) override;
+ void OnMessagesDeleted(const std::string& app_id) override;
+ void OnSendError(
const std::string& app_id,
const GCMClient::SendErrorDetails& send_error_details) override;
- virtual void OnSendAcknowledged(const std::string& app_id,
- const std::string& message_id) override;
+ void OnSendAcknowledged(const std::string& app_id,
+ const std::string& message_id) override;
private:
DISALLOW_COPY_AND_ASSIGN(DefaultGCMAppHandler);
« no previous file with comments | « components/feedback/feedback_uploader_factory.h ('k') | components/gcm_driver/fake_gcm_app_handler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698