Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Unified Diff: components/gcm_driver/fake_gcm_app_handler.h

Issue 666133002: Standardize usage of virtual/override/final in components/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/gcm_driver/default_gcm_app_handler.h ('k') | components/gcm_driver/fake_gcm_client.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/gcm_driver/fake_gcm_app_handler.h
diff --git a/components/gcm_driver/fake_gcm_app_handler.h b/components/gcm_driver/fake_gcm_app_handler.h
index 494353430a8f61d996ebd08cfbe8d8b4715aadcb..29fcd296334f2e4b1c88e28eee0cf3727e7f85ad 100644
--- a/components/gcm_driver/fake_gcm_app_handler.h
+++ b/components/gcm_driver/fake_gcm_app_handler.h
@@ -25,7 +25,7 @@ class FakeGCMAppHandler : public GCMAppHandler {
};
FakeGCMAppHandler();
- virtual ~FakeGCMAppHandler();
+ ~FakeGCMAppHandler() override;
const Event& received_event() const { return received_event_; }
const std::string& app_id() const { return app_id_; }
@@ -38,15 +38,15 @@ class FakeGCMAppHandler : public GCMAppHandler {
void WaitForNotification();
// GCMAppHandler implementation.
- virtual void ShutdownHandler() override;
- virtual void OnMessage(const std::string& app_id,
- const GCMClient::IncomingMessage& message) override;
- virtual void OnMessagesDeleted(const std::string& app_id) override;
- virtual void OnSendError(
+ void ShutdownHandler() override;
+ void OnMessage(const std::string& app_id,
+ const GCMClient::IncomingMessage& message) override;
+ void OnMessagesDeleted(const std::string& app_id) override;
+ void OnSendError(
const std::string& app_id,
const GCMClient::SendErrorDetails& send_error_details) override;
- virtual void OnSendAcknowledged(const std::string& app_id,
- const std::string& message_id) override;
+ void OnSendAcknowledged(const std::string& app_id,
+ const std::string& message_id) override;
private:
void ClearResults();
« no previous file with comments | « components/gcm_driver/default_gcm_app_handler.h ('k') | components/gcm_driver/fake_gcm_client.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698