Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(726)

Unified Diff: components/domain_reliability/service.cc

Issue 666133002: Standardize usage of virtual/override/final in components/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/domain_reliability/service.h ('k') | components/domain_reliability/test_util.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/domain_reliability/service.cc
diff --git a/components/domain_reliability/service.cc b/components/domain_reliability/service.cc
index 9ca7fdd96db200b6b3521b71c7ad6a32a7b78bde..3ce1cb1c147f28a65bc4e435ecb0caab8371a64c 100644
--- a/components/domain_reliability/service.cc
+++ b/components/domain_reliability/service.cc
@@ -35,11 +35,11 @@ class DomainReliabilityServiceImpl : public DomainReliabilityService {
const std::string& upload_reporter_string)
: upload_reporter_string_(upload_reporter_string) {}
- virtual ~DomainReliabilityServiceImpl() {}
+ ~DomainReliabilityServiceImpl() override {}
// DomainReliabilityService implementation:
- virtual scoped_ptr<DomainReliabilityMonitor> CreateMonitor(
+ scoped_ptr<DomainReliabilityMonitor> CreateMonitor(
scoped_refptr<base::SingleThreadTaskRunner> network_task_runner)
override {
DCHECK(!network_task_runner_.get());
@@ -55,8 +55,8 @@ class DomainReliabilityServiceImpl : public DomainReliabilityService {
return monitor.Pass();
}
- virtual void ClearBrowsingData(DomainReliabilityClearMode clear_mode,
- const base::Closure& callback) override {
+ void ClearBrowsingData(DomainReliabilityClearMode clear_mode,
+ const base::Closure& callback) override {
DCHECK(network_task_runner_.get());
network_task_runner_->PostTaskAndReply(
@@ -67,9 +67,8 @@ class DomainReliabilityServiceImpl : public DomainReliabilityService {
callback);
}
- virtual void GetWebUIData(
- const base::Callback<void(scoped_ptr<base::Value>)>& callback)
- const override {
+ void GetWebUIData(const base::Callback<void(scoped_ptr<base::Value>)>&
+ callback) const override {
DCHECK(network_task_runner_.get());
PostTaskAndReplyWithResult(
« no previous file with comments | « components/domain_reliability/service.h ('k') | components/domain_reliability/test_util.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698