Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Side by Side Diff: components/domain_reliability/service.cc

Issue 666133002: Standardize usage of virtual/override/final in components/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « components/domain_reliability/service.h ('k') | components/domain_reliability/test_util.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/domain_reliability/service.h" 5 #include "components/domain_reliability/service.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/callback.h" 8 #include "base/callback.h"
9 #include "base/message_loop/message_loop_proxy.h" 9 #include "base/message_loop/message_loop_proxy.h"
10 #include "base/single_thread_task_runner.h" 10 #include "base/single_thread_task_runner.h"
(...skipping 17 matching lines...) Expand all
28 } 28 }
29 29
30 } // namespace 30 } // namespace
31 31
32 class DomainReliabilityServiceImpl : public DomainReliabilityService { 32 class DomainReliabilityServiceImpl : public DomainReliabilityService {
33 public: 33 public:
34 explicit DomainReliabilityServiceImpl( 34 explicit DomainReliabilityServiceImpl(
35 const std::string& upload_reporter_string) 35 const std::string& upload_reporter_string)
36 : upload_reporter_string_(upload_reporter_string) {} 36 : upload_reporter_string_(upload_reporter_string) {}
37 37
38 virtual ~DomainReliabilityServiceImpl() {} 38 ~DomainReliabilityServiceImpl() override {}
39 39
40 // DomainReliabilityService implementation: 40 // DomainReliabilityService implementation:
41 41
42 virtual scoped_ptr<DomainReliabilityMonitor> CreateMonitor( 42 scoped_ptr<DomainReliabilityMonitor> CreateMonitor(
43 scoped_refptr<base::SingleThreadTaskRunner> network_task_runner) 43 scoped_refptr<base::SingleThreadTaskRunner> network_task_runner)
44 override { 44 override {
45 DCHECK(!network_task_runner_.get()); 45 DCHECK(!network_task_runner_.get());
46 46
47 scoped_ptr<DomainReliabilityMonitor> monitor( 47 scoped_ptr<DomainReliabilityMonitor> monitor(
48 new DomainReliabilityMonitor(upload_reporter_string_, 48 new DomainReliabilityMonitor(upload_reporter_string_,
49 base::MessageLoopProxy::current(), 49 base::MessageLoopProxy::current(),
50 network_task_runner)); 50 network_task_runner));
51 51
52 monitor_ = monitor->MakeWeakPtr(); 52 monitor_ = monitor->MakeWeakPtr();
53 network_task_runner_ = network_task_runner; 53 network_task_runner_ = network_task_runner;
54 54
55 return monitor.Pass(); 55 return monitor.Pass();
56 } 56 }
57 57
58 virtual void ClearBrowsingData(DomainReliabilityClearMode clear_mode, 58 void ClearBrowsingData(DomainReliabilityClearMode clear_mode,
59 const base::Closure& callback) override { 59 const base::Closure& callback) override {
60 DCHECK(network_task_runner_.get()); 60 DCHECK(network_task_runner_.get());
61 61
62 network_task_runner_->PostTaskAndReply( 62 network_task_runner_->PostTaskAndReply(
63 FROM_HERE, 63 FROM_HERE,
64 base::Bind(&DomainReliabilityMonitor::ClearBrowsingData, 64 base::Bind(&DomainReliabilityMonitor::ClearBrowsingData,
65 monitor_, 65 monitor_,
66 clear_mode), 66 clear_mode),
67 callback); 67 callback);
68 } 68 }
69 69
70 virtual void GetWebUIData( 70 void GetWebUIData(const base::Callback<void(scoped_ptr<base::Value>)>&
71 const base::Callback<void(scoped_ptr<base::Value>)>& callback) 71 callback) const override {
72 const override {
73 DCHECK(network_task_runner_.get()); 72 DCHECK(network_task_runner_.get());
74 73
75 PostTaskAndReplyWithResult( 74 PostTaskAndReplyWithResult(
76 network_task_runner_.get(), 75 network_task_runner_.get(),
77 FROM_HERE, 76 FROM_HERE,
78 base::Bind(&GetWebUIDataOnNetworkTaskRunner, monitor_), 77 base::Bind(&GetWebUIDataOnNetworkTaskRunner, monitor_),
79 callback); 78 callback);
80 } 79 }
81 80
82 private: 81 private:
83 std::string upload_reporter_string_; 82 std::string upload_reporter_string_;
84 base::WeakPtr<DomainReliabilityMonitor> monitor_; 83 base::WeakPtr<DomainReliabilityMonitor> monitor_;
85 scoped_refptr<base::SingleThreadTaskRunner> network_task_runner_; 84 scoped_refptr<base::SingleThreadTaskRunner> network_task_runner_;
86 }; 85 };
87 86
88 // static 87 // static
89 DomainReliabilityService* DomainReliabilityService::Create( 88 DomainReliabilityService* DomainReliabilityService::Create(
90 const std::string& upload_reporter_string) { 89 const std::string& upload_reporter_string) {
91 return new DomainReliabilityServiceImpl(upload_reporter_string); 90 return new DomainReliabilityServiceImpl(upload_reporter_string);
92 } 91 }
93 92
94 DomainReliabilityService::~DomainReliabilityService() {} 93 DomainReliabilityService::~DomainReliabilityService() {}
95 94
96 DomainReliabilityService::DomainReliabilityService() {} 95 DomainReliabilityService::DomainReliabilityService() {}
97 96
98 } // namespace domain_reliability 97 } // namespace domain_reliability
OLDNEW
« no previous file with comments | « components/domain_reliability/service.h ('k') | components/domain_reliability/test_util.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698