components/dom_distiller/core/distilled_content_store.h - Issue 666133002: Standardize usage of virtual/override/final in components/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/dom_distiller/core/distilled_content_store.h

Issue 666133002: Standardize usage of virtual/override/final in components/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/dom_distiller/content/web_contents_main_frame_observer.h ('k') | components/dom_distiller/core/distilled_page_prefs_unittests.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/dom_distiller/core/distilled_content_store.h

diff --git a/components/dom_distiller/core/distilled_content_store.h b/components/dom_distiller/core/distilled_content_store.h

index 4312b0153eb7bcc3f7480248eea1597f3071af95..0063dd37166eb4b993277aaafaa0861c12f05d13 100644

--- a/components/dom_distiller/core/distilled_content_store.h

+++ b/components/dom_distiller/core/distilled_content_store.h

@@ -45,14 +45,13 @@ class DistilledContentStore {

class InMemoryContentStore : public DistilledContentStore {

public:

explicit InMemoryContentStore(const int max_num_entries);

- virtual ~InMemoryContentStore();

+ ~InMemoryContentStore() override;

// DistilledContentStore implementation

- virtual void SaveContent(const ArticleEntry& entry,

- const DistilledArticleProto& proto,

- SaveCallback callback) override;

- virtual void LoadContent(const ArticleEntry& entry,

- LoadCallback callback) override;

+ void SaveContent(const ArticleEntry& entry,

+ const DistilledArticleProto& proto,

+ SaveCallback callback) override;

+ void LoadContent(const ArticleEntry& entry, LoadCallback callback) override;

// Synchronously saves the content.

void InjectContent(const ArticleEntry& entry,